From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Jens Kuske <jenskuske@gmail.com>,
Mike Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Vishnu Patekar <vishnupatekar0510@gmail.com>,
Hans de Goede <hdegoede@redhat.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-clk <linux-clk@vger.kernel.org>,
Jean-Francois Moine <moinejf@free.fr>
Subject: Re: [PATCH v3 2/2] clk: sunxi: Refactor A31 PLL6 so that it can be reused
Date: Mon, 1 Feb 2016 20:46:26 +0100 [thread overview]
Message-ID: <20160201194626.GH4652@lukather> (raw)
In-Reply-To: <CAGb2v67v6-BCPp2u7vieCGnCAsHFv4XjnRXvfT1vZNHc_Ok0UA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 701 bytes --]
On Fri, Jan 29, 2016 at 06:14:48PM +0800, Chen-Yu Tsai wrote:
> >> @@ -173,7 +173,7 @@
> >> #clock-cells = <0>;
> >> compatible = "allwinner,sun8i-h3-ahb2-clk";
> >> reg = <0x01c2005c 0x4>;
> >> - clocks = <&ahb1>, <&pll6d2>;
> >> + clocks = <&ahb1>, <&pll6>;
> >
> > According to the datasheet AHB2 really has PLL6 / 2 as parent, not PLL6
> > directly.
>
> Thanks for the save. So we should keep pll6d2_clk.
Indeed thanks for the review. Will fix for v4.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/2] clk: sunxi: Refactor A31 PLL6 so that it can be reused
Date: Mon, 1 Feb 2016 20:46:26 +0100 [thread overview]
Message-ID: <20160201194626.GH4652@lukather> (raw)
In-Reply-To: <CAGb2v67v6-BCPp2u7vieCGnCAsHFv4XjnRXvfT1vZNHc_Ok0UA@mail.gmail.com>
On Fri, Jan 29, 2016 at 06:14:48PM +0800, Chen-Yu Tsai wrote:
> >> @@ -173,7 +173,7 @@
> >> #clock-cells = <0>;
> >> compatible = "allwinner,sun8i-h3-ahb2-clk";
> >> reg = <0x01c2005c 0x4>;
> >> - clocks = <&ahb1>, <&pll6d2>;
> >> + clocks = <&ahb1>, <&pll6>;
> >
> > According to the datasheet AHB2 really has PLL6 / 2 as parent, not PLL6
> > directly.
>
> Thanks for the save. So we should keep pll6d2_clk.
Indeed thanks for the review. Will fix for v4.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160201/48505a6b/attachment.sig>
next prev parent reply other threads:[~2016-02-01 19:46 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 19:22 [PATCH v3 1/2] clk: sunxi: factors: Add missing recalc pointer copy Maxime Ripard
2016-01-28 19:22 ` Maxime Ripard
2016-01-28 19:22 ` [PATCH v3 2/2] clk: sunxi: Refactor A31 PLL6 so that it can be reused Maxime Ripard
2016-01-28 19:22 ` Maxime Ripard
2016-01-29 9:56 ` Chen-Yu Tsai
2016-01-29 9:56 ` Chen-Yu Tsai
2016-01-29 10:02 ` Jens Kuske
2016-01-29 10:02 ` Jens Kuske
2016-01-29 10:14 ` Chen-Yu Tsai
2016-01-29 10:14 ` Chen-Yu Tsai
2016-02-01 19:46 ` Maxime Ripard [this message]
2016-02-01 19:46 ` Maxime Ripard
2016-01-30 17:57 ` Jean-Francois Moine
2016-01-30 17:57 ` Jean-Francois Moine
2016-01-31 12:08 ` Chen-Yu Tsai
2016-01-31 12:08 ` Chen-Yu Tsai
2016-01-31 14:26 ` Jean-Francois Moine
2016-01-31 14:26 ` Jean-Francois Moine
2016-02-01 20:17 ` Maxime Ripard
2016-02-01 20:17 ` Maxime Ripard
2016-02-02 6:52 ` Jean-Francois Moine
2016-02-02 6:52 ` Jean-Francois Moine
2016-02-03 19:07 ` Maxime Ripard
2016-02-03 19:07 ` Maxime Ripard
2016-01-29 6:18 ` [PATCH v3 1/2] clk: sunxi: factors: Add missing recalc pointer copy Chen-Yu Tsai
2016-01-29 6:18 ` Chen-Yu Tsai
2016-01-29 10:37 ` Maxime Ripard
2016-01-29 10:37 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160201194626.GH4652@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=hdegoede@redhat.com \
--cc=jenskuske@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=moinejf@free.fr \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=vishnupatekar0510@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.