From: Matthew Wilcox <willy@linux.intel.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Matthew Wilcox <matthew.r.wilcox@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: Use linear_page_index() in do_fault()
Date: Mon, 1 Feb 2016 15:44:01 -0500 [thread overview]
Message-ID: <20160201204401.GF2948@linux.intel.com> (raw)
In-Reply-To: <20160201130638.GB29337@node.shutemov.name>
On Mon, Feb 01, 2016 at 03:06:38PM +0200, Kirill A. Shutemov wrote:
> On Sun, Jan 31, 2016 at 11:13:21PM +1100, Matthew Wilcox wrote:
> > do_fault assumes that PAGE_SIZE is the same as PAGE_CACHE_SIZE.
> > Use linear_page_index() to calculate pgoff in the correct units.
> >
> > Signed-off-by: Matthew Wilcox <matthew.r.wilcox@intel.com>
>
> Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
>
> 'linear' part of helper name is not relevant any more since we've dropped
> non-linear mappings. Probably, we should rename helpers.
Ah, that's what it was named for. Yes, probably.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy@linux.intel.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Matthew Wilcox <matthew.r.wilcox@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: Use linear_page_index() in do_fault()
Date: Mon, 1 Feb 2016 15:44:01 -0500 [thread overview]
Message-ID: <20160201204401.GF2948@linux.intel.com> (raw)
In-Reply-To: <20160201130638.GB29337@node.shutemov.name>
On Mon, Feb 01, 2016 at 03:06:38PM +0200, Kirill A. Shutemov wrote:
> On Sun, Jan 31, 2016 at 11:13:21PM +1100, Matthew Wilcox wrote:
> > do_fault assumes that PAGE_SIZE is the same as PAGE_CACHE_SIZE.
> > Use linear_page_index() to calculate pgoff in the correct units.
> >
> > Signed-off-by: Matthew Wilcox <matthew.r.wilcox@intel.com>
>
> Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
>
> 'linear' part of helper name is not relevant any more since we've dropped
> non-linear mappings. Probably, we should rename helpers.
Ah, that's what it was named for. Yes, probably.
next prev parent reply other threads:[~2016-02-01 20:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-31 12:13 [PATCH] mm: Use linear_page_index() in do_fault() Matthew Wilcox
2016-01-31 12:13 ` Matthew Wilcox
2016-02-01 13:06 ` Kirill A. Shutemov
2016-02-01 13:06 ` Kirill A. Shutemov
2016-02-01 20:44 ` Matthew Wilcox [this message]
2016-02-01 20:44 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160201204401.GF2948@linux.intel.com \
--to=willy@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matthew.r.wilcox@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.