From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 08/10] libimxvpuapi: add new package
Date: Mon, 1 Feb 2016 21:42:18 +0100 [thread overview]
Message-ID: <20160201214218.3eb39852@free-electrons.com> (raw)
In-Reply-To: <1454154357-31625-9-git-send-email-gary.bisson@boundarydevices.com>
Dear Gary Bisson,
On Sat, 30 Jan 2016 12:45:55 +0100, Gary Bisson wrote:
> diff --git a/package/Config.in b/package/Config.in
> index 09c2b40..d3e5e30 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1033,6 +1033,7 @@ menu "Multimedia"
> source "package/libfslparser/Config.in"
> source "package/libfslvpuwrap/Config.in"
> source "package/libhdhomerun/Config.in"
> + source "package/libimxvpuapi/Config.in"
Why isn't it part of the package/freescale/ directory ? Because it
isn't sourced from the same site ?
> source "package/libmatroska/Config.in"
> source "package/libmms/Config.in"
> source "package/libmpeg2/Config.in"
> diff --git a/package/libimxvpuapi/Config.in b/package/libimxvpuapi/Config.in
> new file mode 100644
> index 0000000..222aa76
> --- /dev/null
> +++ b/package/libimxvpuapi/Config.in
> @@ -0,0 +1,10 @@
> +config BR2_PACKAGE_LIBIMXVPUAPI
> + bool "libimxvpuapi"
> + depends on BR2_arm # Only relevant for i.MX
> + select BR2_PACKAGE_FREESCALE_IMX
> + select BR2_PACKAGE_IMX_VPU
I am wondering if the first one shouldn't be a "depends on", but I'm
not sure. What do other think ?
> + help
> + This library provides an API for using the iMX6 VPU video engine. It
> + is an alternative to Freescale's VPU wrapper. Both the wrapper and
> + this library are layered on top of imx-vpu, the low-level iMX6 VPU
> + interface.
A URL to the upstream web page would be good. A github page is fine as
a fallback if there's no real upstream web site.
> diff --git a/package/libimxvpuapi/libimxvpuapi.mk b/package/libimxvpuapi/libimxvpuapi.mk
> new file mode 100644
> index 0000000..ff9282d
> --- /dev/null
> +++ b/package/libimxvpuapi/libimxvpuapi.mk
> @@ -0,0 +1,35 @@
> +################################################################################
> +#
> +# libimxvpuapi
> +#
> +################################################################################
> +
> +LIBIMXVPUAPI_VERSION = 0.10.1
> +LIBIMXVPUAPI_SITE = $(call github,Freescale,libimxvpuapi,$(LIBIMXVPUAPI_VERSION))
> +LIBIMXVPUAPI_LICENSE = LGPLv2.1
License seems to be LGPLv2.1+.
Also, you forgot to include a hash file. Could you fix those issues and
send an updated version?
Thanks a lot!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-02-01 20:42 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-30 11:45 [Buildroot] [PATCH 00/10] Update most Freescale packages Gary Bisson
2016-01-30 11:45 ` [Buildroot] [PATCH 01/10] firmware-imx: bump to version 5.2 Gary Bisson
2016-02-01 20:39 ` Thomas Petazzoni
2016-02-01 20:56 ` Gary Bisson
2016-01-30 11:45 ` [Buildroot] [PATCH 02/10] imx-kobs: bump to version 5.1 Gary Bisson
2016-02-01 20:39 ` Thomas Petazzoni
2016-01-30 11:45 ` [Buildroot] [PATCH 03/10] imx-lib: " Gary Bisson
2016-02-01 20:39 ` Thomas Petazzoni
2016-01-30 11:45 ` [Buildroot] [PATCH 04/10] freescale-imx: remove FREESCALE_IMX_VERSION Gary Bisson
2016-02-01 20:39 ` Thomas Petazzoni
2016-01-30 11:45 ` [Buildroot] [PATCH 05/10] libfslcodec: bump to version 4.0.7 Gary Bisson
2016-02-01 20:39 ` Thomas Petazzoni
2016-01-30 11:45 ` [Buildroot] [PATCH 06/10] libfslparser: " Gary Bisson
2016-02-01 20:39 ` Thomas Petazzoni
2016-01-30 11:45 ` [Buildroot] [PATCH 07/10] libfslvpuwrap: bump to version 1.0.61 Gary Bisson
2016-02-01 20:39 ` Thomas Petazzoni
2016-01-30 11:45 ` [Buildroot] [PATCH 08/10] libimxvpuapi: add new package Gary Bisson
2016-02-01 20:42 ` Thomas Petazzoni [this message]
2016-02-01 21:07 ` Gary Bisson
2016-02-01 21:17 ` Thomas Petazzoni
2016-01-30 11:45 ` [Buildroot] [PATCH 09/10] gst1-plugins-bad: add install to staging directory Gary Bisson
2016-02-01 20:42 ` Thomas Petazzoni
2016-01-30 11:45 ` [Buildroot] [PATCH 10/10] gst1-imx: bump to version 0.12.0 Gary Bisson
2016-02-01 20:44 ` Thomas Petazzoni
2016-02-01 21:20 ` Gary Bisson
2016-02-01 22:27 ` Thomas Petazzoni
2016-02-01 22:49 ` Gary Bisson
2016-02-02 8:56 ` Arnout Vandecappelle
2016-02-02 9:07 ` Gary Bisson
2016-02-02 8:51 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160201214218.3eb39852@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.