All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 10/10] gst1-imx: bump to version 0.12.0
Date: Mon, 1 Feb 2016 21:44:37 +0100	[thread overview]
Message-ID: <20160201214437.66ddff9e@free-electrons.com> (raw)
In-Reply-To: <1454154357-31625-11-git-send-email-gary.bisson@boundarydevices.com>

Dear Gary Bisson,

On Sat, 30 Jan 2016 12:45:57 +0100, Gary Bisson wrote:

> -config BR2_PACKAGE_GST1_IMX
> +menuconfig BR2_PACKAGE_GST1_IMX
>  	bool "gst1-imx"
>  	depends on BR2_LINUX_KERNEL
>  	depends on BR2_arm # Only relevant for i.MX
> -	depends on BR2_TOOLCHAIN_USES_GLIBC # imx-gpu-viv
> -	depends on BR2_PACKAGE_IMX_GPU_VIV

So it no longer depends on the GPU stuff ?

> -	depends on BR2_PACKAGE_LIBFSLVPUWRAP
>  	select BR2_PACKAGE_GST1_PLUGINS_BASE
> +	select BR2_PACKAGE_GST1_IMX_IPU_PLUGIN
> +	select BR2_PACKAGE_GST1_IMX_PXP_PLUGIN

This is weird. If you "select" these options here, it means that there
is no way to disable those options. So why are they options in the
first place ?

>  	help
>  	  This is a set of GStreamer 1.0 plugins for plugins for Freescale's
>  	  i.MX6 platforms, with emphasis on video en/decoding using the VPU
> @@ -25,3 +19,49 @@ config BR2_PACKAGE_GST1_IMX
>  	  The software as a whole is currently in beta stage.
>  
>  	  https://github.com/Freescale/gstreamer-imx
> +
> +if BR2_PACKAGE_GST1_IMX
> +
> +config BR2_PACKAGE_GST1_IMX_IPU_PLUGIN
> +	bool "IPU plugin"
> +	help
> +	  IPU plugin library

This one.

> +
> +config BR2_PACKAGE_GST1_IMX_PXP_PLUGIN
> +	bool "PXP plugin"
> +	help
> +	  PXP plugin library

And this one.

> +# Required by imx-gpu-viv
> +comment "GPU sinks need an (e)glibc toolchain"
> +	depends on !BR2_TOOLCHAIN_USES_GLIBC

Ah ok, here is the GPU dependency.

> diff --git a/package/gstreamer1/gst1-imx/gst1-imx.mk b/package/gstreamer1/gst1-imx/gst1-imx.mk
> index 8ede8ad..f3eac0a 100644
> --- a/package/gstreamer1/gst1-imx/gst1-imx.mk
> +++ b/package/gstreamer1/gst1-imx/gst1-imx.mk
> @@ -4,7 +4,7 @@
>  #
>  ################################################################################
>  
> -GST1_IMX_VERSION = 0.11.1
> +GST1_IMX_VERSION = 0.12.0
>  GST1_IMX_SITE = $(call github,Freescale,gstreamer-imx,$(GST1_IMX_VERSION))
>  
>  GST1_IMX_LICENSE = LGPLv2+
> @@ -13,13 +13,23 @@ GST1_IMX_LICENSE_FILES = LICENSE
>  GST1_IMX_INSTALL_STAGING = YES
>  
>  GST1_IMX_DEPENDENCIES += host-pkgconf host-python \
> -	imx-gpu-viv gstreamer1 gst1-plugins-base libfslvpuwrap
> +	gstreamer1 gst1-plugins-base
>  
>  # needs access to imx-specific kernel headers
>  GST1_IMX_DEPENDENCIES += linux
>  GST1_IMX_CONF_OPTS += --prefix="/usr" \
>  	--kernel-headers="$(LINUX_DIR)/include"
>  
> +ifeq ($(BR2_PACKAGE_GST1_IMX_V4L2_PLUGIN),y)
> +GST1_IMX_DEPENDENCIES += gst1-plugins-bad
> +endif
> +
> +ifeq ($(BR2_PACKAGE_GST1_IMX_VPU_PLUGIN),y)
> +GST1_IMX_DEPENDENCIES += libimxvpuapi
> +endif
> +
> +ifeq ($(BR2_PACKAGE_GST1_IMX_EGL_PLUGIN),y)
> +GST1_IMX_DEPENDENCIES += imx-gpu-viv
>  ifeq ($(BR2_PACKAGE_XLIB_LIBX11),y)
>  GST1_IMX_DEPENDENCIES += xlib_libX11
>  GST1_IMX_CONF_OPTS += --egl-platform=x11
> @@ -31,6 +41,7 @@ else
>  GST1_IMX_CONF_OPTS += --egl-platform=fb
>  endif
>  endif
> +endif
>  
>  define GST1_IMX_CONFIGURE_CMDS
>  	cd $(@D); \

Also, please add a hash file. The rest looks good. Can you fix and
resend ?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2016-02-01 20:44 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-30 11:45 [Buildroot] [PATCH 00/10] Update most Freescale packages Gary Bisson
2016-01-30 11:45 ` [Buildroot] [PATCH 01/10] firmware-imx: bump to version 5.2 Gary Bisson
2016-02-01 20:39   ` Thomas Petazzoni
2016-02-01 20:56     ` Gary Bisson
2016-01-30 11:45 ` [Buildroot] [PATCH 02/10] imx-kobs: bump to version 5.1 Gary Bisson
2016-02-01 20:39   ` Thomas Petazzoni
2016-01-30 11:45 ` [Buildroot] [PATCH 03/10] imx-lib: " Gary Bisson
2016-02-01 20:39   ` Thomas Petazzoni
2016-01-30 11:45 ` [Buildroot] [PATCH 04/10] freescale-imx: remove FREESCALE_IMX_VERSION Gary Bisson
2016-02-01 20:39   ` Thomas Petazzoni
2016-01-30 11:45 ` [Buildroot] [PATCH 05/10] libfslcodec: bump to version 4.0.7 Gary Bisson
2016-02-01 20:39   ` Thomas Petazzoni
2016-01-30 11:45 ` [Buildroot] [PATCH 06/10] libfslparser: " Gary Bisson
2016-02-01 20:39   ` Thomas Petazzoni
2016-01-30 11:45 ` [Buildroot] [PATCH 07/10] libfslvpuwrap: bump to version 1.0.61 Gary Bisson
2016-02-01 20:39   ` Thomas Petazzoni
2016-01-30 11:45 ` [Buildroot] [PATCH 08/10] libimxvpuapi: add new package Gary Bisson
2016-02-01 20:42   ` Thomas Petazzoni
2016-02-01 21:07     ` Gary Bisson
2016-02-01 21:17       ` Thomas Petazzoni
2016-01-30 11:45 ` [Buildroot] [PATCH 09/10] gst1-plugins-bad: add install to staging directory Gary Bisson
2016-02-01 20:42   ` Thomas Petazzoni
2016-01-30 11:45 ` [Buildroot] [PATCH 10/10] gst1-imx: bump to version 0.12.0 Gary Bisson
2016-02-01 20:44   ` Thomas Petazzoni [this message]
2016-02-01 21:20     ` Gary Bisson
2016-02-01 22:27       ` Thomas Petazzoni
2016-02-01 22:49         ` Gary Bisson
2016-02-02  8:56           ` Arnout Vandecappelle
2016-02-02  9:07             ` Gary Bisson
2016-02-02  8:51   ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160201214437.66ddff9e@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.