All of lore.kernel.org
 help / color / mirror / Atom feed
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] ARM: dts: imx53: add ethernet PHY supply regulator
Date: Tue, 2 Feb 2016 14:53:07 +0800	[thread overview]
Message-ID: <20160202065306.GH8307@tiger> (raw)
In-Reply-To: <1453295362-18798-2-git-send-email-LW@KARO-electronics.de>

On Wed, Jan 20, 2016 at 02:09:19PM +0100, Lothar Wa?mann wrote:
> Signed-off-by: Lothar Wa?mann <LW@KARO-electronics.de>
> ---
>  arch/arm/boot/dts/imx53-tx53.dtsi | 40 ++++++++++++++++++++++++++++++---------
>  1 file changed, 31 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx53-tx53.dtsi b/arch/arm/boot/dts/imx53-tx53.dtsi
> index d3e50b2..8f08389 100644
> --- a/arch/arm/boot/dts/imx53-tx53.dtsi
> +++ b/arch/arm/boot/dts/imx53-tx53.dtsi
> @@ -87,9 +87,20 @@
>  			regulator-max-microvolt = <3300000>;
>  		};
>  
> -		reg_can_xcvr: regulator at 2 {
> +		reg_3v3_etn: regulator at 2 {

Why cannot this be added as regulator at 5 to avoid changing every node?

>  			compatible = "regulator-fixed";
>  			reg = <2>;
> +			regulator-name = "ETN 3V3";
> +			regulator-min-microvolt = <3300000>;
> +			regulator-max-microvolt = <3300000>;
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&pinctrl_etn_phy>;
> +			gpio = <&gpio3 20 GPIO_ACTIVE_HIGH>;
> +		};
> +
> +		reg_can_xcvr: regulator at 3 {
> +			compatible = "regulator-fixed";
> +			reg = <3>;
>  			regulator-name = "CAN XCVR";
>  			regulator-min-microvolt = <3300000>;
>  			regulator-max-microvolt = <3300000>;
> @@ -98,9 +109,9 @@
>  			gpio = <&gpio4 21 GPIO_ACTIVE_HIGH>;
>  		};
>  
> -		reg_usbh1_vbus: regulator at 3 {
> +		reg_usbh1_vbus: regulator at 4 {
>  			compatible = "regulator-fixed";
> -			reg = <3>;
> +			reg = <4>;
>  			regulator-name = "usbh1_vbus";
>  			regulator-min-microvolt = <5000000>;
>  			regulator-max-microvolt = <5000000>;
> @@ -110,9 +121,9 @@
>  			enable-active-high;
>  		};
>  
> -		reg_usbotg_vbus: regulator at 4 {
> +		reg_usbotg_vbus: regulator at 5 {
>  			compatible = "regulator-fixed";
> -			reg = <4>;
> +			reg = <5>;
>  			regulator-name = "usbotg_vbus";
>  			regulator-min-microvolt = <5000000>;
>  			regulator-max-microvolt = <5000000>;
> @@ -204,13 +215,20 @@
>  	phy-mode = "rmii";
>  	phy-reset-gpios = <&gpio7 6 GPIO_ACTIVE_HIGH>;
>  	phy-handle = <&phy0>;
> +	phy-supply = <&reg_3v3_etn>;
>  	mac-address = [000000000000]; /* placeholder; will be overwritten by bootloader */
>  	status = "okay";
>  
> -	phy0: ethernet-phy at 0 {
> -		interrupt-parent = <&gpio2>;
> -		interrupts = <4>;
> -		device_type = "ethernet-phy";
> +	mdio {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		phy0: ethernet-phy at 0 {
> +			compatible = "ethernet-phy-id0007.c0f1", "ethernet-phy-ieee802.3-c22";
> +			reg = <0>;
> +			interrupt-parent = <&gpio2>;
> +			interrupts = <4>;
> +		};

This should be a separate change.

Shawn

>  	};
>  };
>  
> @@ -309,6 +327,10 @@
>  			fsl,pins = <MX53_PAD_DISP0_DAT0__GPIO4_21 0xe0>; /* Flexcan XCVR enable */
>  		};
>  
> +		pinctrl_etn_phy: etn-phygrp {
> +			fsl,pins = <MX53_PAD_EIM_D20__GPIO3_20 0xe0>; /* ETN PHY Power enable */
> +		};
> +
>  		pinctrl_ds1339: ds1339grp {
>  			fsl,pins = <MX53_PAD_DI0_PIN4__GPIO4_20 0xe0>;
>  		};
> -- 
> 2.1.4
> 
> 

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: "Lothar Waßmann" <LW@KARO-electronics.de>
Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Pawel Moll <pawel.moll@arm.com>, Rob Herring <robh+dt@kernel.org>,
	Russell King <linux@arm.linux.org.uk>,
	Sascha Hauer <kernel@pengutronix.de>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] ARM: dts: imx53: add ethernet PHY supply regulator
Date: Tue, 2 Feb 2016 14:53:07 +0800	[thread overview]
Message-ID: <20160202065306.GH8307@tiger> (raw)
In-Reply-To: <1453295362-18798-2-git-send-email-LW@KARO-electronics.de>

On Wed, Jan 20, 2016 at 02:09:19PM +0100, Lothar Waßmann wrote:
> Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
> ---
>  arch/arm/boot/dts/imx53-tx53.dtsi | 40 ++++++++++++++++++++++++++++++---------
>  1 file changed, 31 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx53-tx53.dtsi b/arch/arm/boot/dts/imx53-tx53.dtsi
> index d3e50b2..8f08389 100644
> --- a/arch/arm/boot/dts/imx53-tx53.dtsi
> +++ b/arch/arm/boot/dts/imx53-tx53.dtsi
> @@ -87,9 +87,20 @@
>  			regulator-max-microvolt = <3300000>;
>  		};
>  
> -		reg_can_xcvr: regulator@2 {
> +		reg_3v3_etn: regulator@2 {

Why cannot this be added as regulator@5 to avoid changing every node?

>  			compatible = "regulator-fixed";
>  			reg = <2>;
> +			regulator-name = "ETN 3V3";
> +			regulator-min-microvolt = <3300000>;
> +			regulator-max-microvolt = <3300000>;
> +			pinctrl-names = "default";
> +			pinctrl-0 = <&pinctrl_etn_phy>;
> +			gpio = <&gpio3 20 GPIO_ACTIVE_HIGH>;
> +		};
> +
> +		reg_can_xcvr: regulator@3 {
> +			compatible = "regulator-fixed";
> +			reg = <3>;
>  			regulator-name = "CAN XCVR";
>  			regulator-min-microvolt = <3300000>;
>  			regulator-max-microvolt = <3300000>;
> @@ -98,9 +109,9 @@
>  			gpio = <&gpio4 21 GPIO_ACTIVE_HIGH>;
>  		};
>  
> -		reg_usbh1_vbus: regulator@3 {
> +		reg_usbh1_vbus: regulator@4 {
>  			compatible = "regulator-fixed";
> -			reg = <3>;
> +			reg = <4>;
>  			regulator-name = "usbh1_vbus";
>  			regulator-min-microvolt = <5000000>;
>  			regulator-max-microvolt = <5000000>;
> @@ -110,9 +121,9 @@
>  			enable-active-high;
>  		};
>  
> -		reg_usbotg_vbus: regulator@4 {
> +		reg_usbotg_vbus: regulator@5 {
>  			compatible = "regulator-fixed";
> -			reg = <4>;
> +			reg = <5>;
>  			regulator-name = "usbotg_vbus";
>  			regulator-min-microvolt = <5000000>;
>  			regulator-max-microvolt = <5000000>;
> @@ -204,13 +215,20 @@
>  	phy-mode = "rmii";
>  	phy-reset-gpios = <&gpio7 6 GPIO_ACTIVE_HIGH>;
>  	phy-handle = <&phy0>;
> +	phy-supply = <&reg_3v3_etn>;
>  	mac-address = [000000000000]; /* placeholder; will be overwritten by bootloader */
>  	status = "okay";
>  
> -	phy0: ethernet-phy@0 {
> -		interrupt-parent = <&gpio2>;
> -		interrupts = <4>;
> -		device_type = "ethernet-phy";
> +	mdio {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		phy0: ethernet-phy@0 {
> +			compatible = "ethernet-phy-id0007.c0f1", "ethernet-phy-ieee802.3-c22";
> +			reg = <0>;
> +			interrupt-parent = <&gpio2>;
> +			interrupts = <4>;
> +		};

This should be a separate change.

Shawn

>  	};
>  };
>  
> @@ -309,6 +327,10 @@
>  			fsl,pins = <MX53_PAD_DISP0_DAT0__GPIO4_21 0xe0>; /* Flexcan XCVR enable */
>  		};
>  
> +		pinctrl_etn_phy: etn-phygrp {
> +			fsl,pins = <MX53_PAD_EIM_D20__GPIO3_20 0xe0>; /* ETN PHY Power enable */
> +		};
> +
>  		pinctrl_ds1339: ds1339grp {
>  			fsl,pins = <MX53_PAD_DI0_PIN4__GPIO4_20 0xe0>;
>  		};
> -- 
> 2.1.4
> 
> 

  reply	other threads:[~2016-02-02  6:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-20 13:09 [PATCH 0/4] ARM: dts: imx53: update Ka-Ro electronics TX53 module support Lothar Waßmann
2016-01-20 13:09 ` Lothar Waßmann
2016-01-20 13:09 ` Lothar Waßmann
2016-01-20 13:09 ` [PATCH 1/4] ARM: dts: imx53: add ethernet PHY supply regulator Lothar Waßmann
2016-01-20 13:09   ` Lothar Waßmann
2016-02-02  6:53   ` Shawn Guo [this message]
2016-02-02  6:53     ` Shawn Guo
2016-01-20 13:09 ` [PATCH 2/4] ARM: dts: imx53: fix LVDS data-mapping and data-width Lothar Waßmann
2016-01-20 13:09   ` Lothar Waßmann
2016-01-20 13:09 ` [PATCH 3/4] ARM: dts: imx53: add display timing for NL12880BC20 Lothar Waßmann
2016-01-20 13:09   ` Lothar Waßmann
2016-01-20 13:09 ` [PATCH 4/4] ARM: dts: imx53-tx53: set correct mclk frequency Lothar Waßmann
2016-01-20 13:09   ` Lothar Waßmann
2016-02-02  7:01 ` [PATCH 0/4] ARM: dts: imx53: update Ka-Ro electronics TX53 module support Shawn Guo
2016-02-02  7:01   ` Shawn Guo
2016-02-02  7:01   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160202065306.GH8307@tiger \
    --to=shawnguo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.