From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: dts: imx6*-hummingboard: fix pcie reset GPIO specification
Date: Tue, 2 Feb 2016 15:34:47 +0800 [thread overview]
Message-ID: <20160202073446.GJ8307@tiger> (raw)
In-Reply-To: <CAOMZO5Ciq-kq4xQm4TH+dF3cdYxFfWUmvuykvorZ-oaEoyBWFQ@mail.gmail.com>
On Wed, Jan 27, 2016 at 07:07:38PM -0200, Fabio Estevam wrote:
> On Wed, Jan 27, 2016 at 6:24 PM, Russell King
> <rmk+kernel@arm.linux.org.uk> wrote:
> > PCIe reset signals are active low, and our GPIO for this is directly
> > connected to the PCIe reset. However, as the PCIe driver does not use
> > the flag, the specification of '0' flags (which means active high) has
> > not been noticed. Correct this oversight, and switch to using the
>
> Yes, the mx6 pci driver did not use the flag, but it does now since 5c5fb40de8f1
> ("PCI: imx6: Add support for active-low reset GPIO"), so it would be
> better to adjust the commit log.
I updated the commit log a bit and applied the series.
Shawn
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Fabio Estevam <festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Russell King <rmk+kernel-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH 3/3] ARM: dts: imx6*-hummingboard: fix pcie reset GPIO specification
Date: Tue, 2 Feb 2016 15:34:47 +0800 [thread overview]
Message-ID: <20160202073446.GJ8307@tiger> (raw)
In-Reply-To: <CAOMZO5Ciq-kq4xQm4TH+dF3cdYxFfWUmvuykvorZ-oaEoyBWFQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Wed, Jan 27, 2016 at 07:07:38PM -0200, Fabio Estevam wrote:
> On Wed, Jan 27, 2016 at 6:24 PM, Russell King
> <rmk+kernel-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org> wrote:
> > PCIe reset signals are active low, and our GPIO for this is directly
> > connected to the PCIe reset. However, as the PCIe driver does not use
> > the flag, the specification of '0' flags (which means active high) has
> > not been noticed. Correct this oversight, and switch to using the
>
> Yes, the mx6 pci driver did not use the flag, but it does now since 5c5fb40de8f1
> ("PCI: imx6: Add support for active-low reset GPIO"), so it would be
> better to adjust the commit log.
I updated the commit log a bit and applied the series.
Shawn
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-02-02 7:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 20:24 [PATCH 3/3] ARM: dts: imx6*-hummingboard: fix pcie reset GPIO specification Russell King
2016-01-27 20:24 ` Russell King
2016-01-27 21:07 ` Fabio Estevam
2016-01-27 21:07 ` Fabio Estevam
2016-02-02 7:34 ` Shawn Guo [this message]
2016-02-02 7:34 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160202073446.GJ8307@tiger \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.