From: Alan.Robinson@ts.fujitsu.com (Alan Robinson)
To: Juergen Gross <jgross@suse.com>
Cc: "george.dunlap@eu.citrix.com" <george.dunlap@eu.citrix.com>,
"dario.faggioli@citrix.com" <dario.faggioli@citrix.com>,
"jbeulich@suse.com" <jbeulich@suse.com>,
"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH] xen: recalculate per-cpupool credits when updating timeslice
Date: Tue, 2 Feb 2016 08:55:11 +0100 [thread overview]
Message-ID: <20160202075511.GA23968@ts.fujitsu.com> (raw)
In-Reply-To: <1454062908-32013-1-git-send-email-jgross@suse.com>
On Fri, Jan 29, 2016 at 11:21:48AM +0100, Juergen Gross wrote:
> When modifying the timeslice of the credit scheduler in a cpupool the
> cpupool global credit value (n_cpus * credits_per_tslice) isn't
> recalculated. This will lead to wrong scheduling decisions later.
>
> Do the recalculation when updating the timeslice.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
We had notice that the quota's were not working after the timeslice
was changed in a mono-cpupool running two guests doing 'for loops'.
Applied Juergen's patch to a SuSE xen-4.4.3_02-26.2 rpm, the patch
was offset by 6 lines. The guests now observe the quotas when the
timeslice is changed.
Tested-by: Alan.Robinson <alan.robinson@ts.fujitsu.com>
--
Sent from my Fujitsu Primergy RXI300 IA64
Firmenangaben: Fujitsu Technology Solutions GmbH / ts.fujitsu.com/imprint
prev parent reply other threads:[~2016-02-02 7:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 10:21 [PATCH] xen: recalculate per-cpupool credits when updating timeslice Juergen Gross
2016-01-29 10:46 ` Jan Beulich
[not found] ` <56AB511402000078000CC59C@suse.com>
2016-01-29 10:59 ` Juergen Gross
2016-02-02 9:53 ` Dario Faggioli
2016-02-02 10:35 ` Juergen Gross
2016-02-02 11:33 ` Dario Faggioli
2016-02-02 7:55 ` Alan Robinson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160202075511.GA23968@ts.fujitsu.com \
--to=alan.robinson@ts.fujitsu.com \
--cc=dario.faggioli@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.