From: Vladimir Davydov <vdavydov@virtuozzo.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.cz>,
linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH v2 5/5] mm: workingset: per-cgroup cache thrash detection
Date: Tue, 2 Feb 2016 17:34:54 +0300 [thread overview]
Message-ID: <20160202143454.GC21016@esperanza> (raw)
In-Reply-To: <1454090047-1790-6-git-send-email-hannes@cmpxchg.org>
On Fri, Jan 29, 2016 at 12:54:07PM -0500, Johannes Weiner wrote:
> Cache thrash detection (see a528910e12ec "mm: thrash detection-based
> file cache sizing" for details) currently only works on the system
> level, not inside cgroups. Worse, as the refaults are compared to the
> global number of active cache, cgroups might wrongfully get all their
> refaults activated when their pages are hotter than those of others.
>
> Move the refault machinery from the zone to the lruvec, and then tag
> eviction entries with the memcg ID. This makes the thrash detection
> work correctly inside cgroups.
>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Reviewed-by: Vladimir Davydov <vdavydov@virtuozzo.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Davydov <vdavydov@virtuozzo.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.cz>, <linux-mm@kvack.org>,
<cgroups@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<kernel-team@fb.com>
Subject: Re: [PATCH v2 5/5] mm: workingset: per-cgroup cache thrash detection
Date: Tue, 2 Feb 2016 17:34:54 +0300 [thread overview]
Message-ID: <20160202143454.GC21016@esperanza> (raw)
In-Reply-To: <1454090047-1790-6-git-send-email-hannes@cmpxchg.org>
On Fri, Jan 29, 2016 at 12:54:07PM -0500, Johannes Weiner wrote:
> Cache thrash detection (see a528910e12ec "mm: thrash detection-based
> file cache sizing" for details) currently only works on the system
> level, not inside cgroups. Worse, as the refaults are compared to the
> global number of active cache, cgroups might wrongfully get all their
> refaults activated when their pages are hotter than those of others.
>
> Move the refault machinery from the zone to the lruvec, and then tag
> eviction entries with the memcg ID. This makes the thrash detection
> work correctly inside cgroups.
>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Reviewed-by: Vladimir Davydov <vdavydov@virtuozzo.com>
next prev parent reply other threads:[~2016-02-02 14:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 17:54 [PATCH v2 0/5] mm: workingset: per-cgroup thrash detection Johannes Weiner
2016-01-29 17:54 ` Johannes Weiner
2016-01-29 17:54 ` [PATCH v2 1/5] mm: memcontrol: generalize locking for the page->mem_cgroup binding Johannes Weiner
2016-01-29 17:54 ` Johannes Weiner
[not found] ` <1454090047-1790-2-git-send-email-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>
2016-02-02 14:18 ` Vladimir Davydov
2016-02-02 14:18 ` Vladimir Davydov
2016-02-02 14:18 ` Vladimir Davydov
2016-01-29 17:54 ` [PATCH v2 2/5] mm: workingset: #define radix entry eviction mask Johannes Weiner
2016-01-29 17:54 ` Johannes Weiner
2016-01-29 17:54 ` [PATCH v2 3/5] mm: workingset: separate shadow unpacking and refault calculation Johannes Weiner
2016-01-29 17:54 ` Johannes Weiner
2016-01-29 17:54 ` [PATCH v2 4/5] mm: workingset: eviction buckets for bigmem/lowbit machines Johannes Weiner
2016-01-29 17:54 ` Johannes Weiner
2016-01-29 17:54 ` [PATCH v2 5/5] mm: workingset: per-cgroup cache thrash detection Johannes Weiner
2016-01-29 17:54 ` Johannes Weiner
2016-02-02 14:34 ` Vladimir Davydov [this message]
2016-02-02 14:34 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160202143454.GC21016@esperanza \
--to=vdavydov@virtuozzo.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.