From: Will Deacon <will.deacon@arm.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org,
Catalin Marinas <catalin.marinas@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/5] Clean up warnings (part 2, asm/pci-bridge.h)
Date: Wed, 3 Feb 2016 09:25:02 +0000 [thread overview]
Message-ID: <20160203092502.GA11376@arm.com> (raw)
In-Reply-To: <20160202193026.9258.7573.stgit@bhelgaas-glaptop2.roam.corp.google.com>
On Tue, Feb 02, 2016 at 01:38:26PM -0600, Bjorn Helgaas wrote:
> We've had some non-arch-specific stuff (pci_has_flag() and associated
> definitions like PCI_PROBE_ONLY) in asm/pci-bridge.h. This leads to
> warnings like:
>
> drivers/pci/host/pcie-designware.c:562:20: error: 'PCI_PROBE_ONLY' undeclared (first use in this function)
> drivers/pci/host/pcie-designware.c:562:7: error: implicit declaration of function 'pci_has_flag' [-Werror=implicit-function-declaration]
>
> because arches don't consistently supply asm/pci-bridge.h, and several
> drivers include it when they shouldn't.
>
> This series moves the generic stuff to linux/pci.h, so it's the same for
> everybody, and removes the now-empty asm-generic/pci-bridge.h.
>
> There still a few arches that provide asm/pci-bridge.h (microblaze,
> powerpc, and xtensa), but now they contain truly arch-dependent things like
> struct pci_controller definitions, and they're only included by
> arch-specific files.
For the arm64 bits:
Acked-by: Will Deacon <will.deacon@arm.com>
Will
WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/5] Clean up warnings (part 2, asm/pci-bridge.h)
Date: Wed, 3 Feb 2016 09:25:02 +0000 [thread overview]
Message-ID: <20160203092502.GA11376@arm.com> (raw)
In-Reply-To: <20160202193026.9258.7573.stgit@bhelgaas-glaptop2.roam.corp.google.com>
On Tue, Feb 02, 2016 at 01:38:26PM -0600, Bjorn Helgaas wrote:
> We've had some non-arch-specific stuff (pci_has_flag() and associated
> definitions like PCI_PROBE_ONLY) in asm/pci-bridge.h. This leads to
> warnings like:
>
> drivers/pci/host/pcie-designware.c:562:20: error: 'PCI_PROBE_ONLY' undeclared (first use in this function)
> drivers/pci/host/pcie-designware.c:562:7: error: implicit declaration of function 'pci_has_flag' [-Werror=implicit-function-declaration]
>
> because arches don't consistently supply asm/pci-bridge.h, and several
> drivers include it when they shouldn't.
>
> This series moves the generic stuff to linux/pci.h, so it's the same for
> everybody, and removes the now-empty asm-generic/pci-bridge.h.
>
> There still a few arches that provide asm/pci-bridge.h (microblaze,
> powerpc, and xtensa), but now they contain truly arch-dependent things like
> struct pci_controller definitions, and they're only included by
> arch-specific files.
For the arm64 bits:
Acked-by: Will Deacon <will.deacon@arm.com>
Will
next prev parent reply other threads:[~2016-02-03 9:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 19:38 [PATCH 0/5] Clean up warnings (part 2, asm/pci-bridge.h) Bjorn Helgaas
2016-02-02 19:38 ` Bjorn Helgaas
2016-02-02 19:38 ` [PATCH 1/5] PCI: Move pci_set_flags() from asm-generic/pci-bridge.h to linux/pci.h Bjorn Helgaas
2016-02-02 19:38 ` Bjorn Helgaas
2016-02-02 19:38 ` [PATCH 2/5] PCI: Remove includes of empty asm-generic/pci-bridge.h Bjorn Helgaas
2016-02-02 19:38 ` Bjorn Helgaas
2016-02-02 19:38 ` [PATCH 3/5] ARM64: PCI: Remove generated include of asm-generic/pci-bridge.h Bjorn Helgaas
2016-02-02 19:38 ` Bjorn Helgaas
2016-02-02 19:38 ` [PATCH 4/5] PCI: Remove empty asm-generic/pci-bridge.h Bjorn Helgaas
2016-02-02 19:38 ` Bjorn Helgaas
2016-02-02 19:39 ` [PATCH 5/5] PCI: Remove includes of asm/pci-bridge.h Bjorn Helgaas
2016-02-02 19:39 ` Bjorn Helgaas
2016-02-03 9:25 ` Will Deacon [this message]
2016-02-03 9:25 ` [PATCH 0/5] Clean up warnings (part 2, asm/pci-bridge.h) Will Deacon
2016-02-05 22:36 ` Bjorn Helgaas
2016-02-05 22:36 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160203092502.GA11376@arm.com \
--to=will.deacon@arm.com \
--cc=bhelgaas@google.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.