From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Marcin Wojtas <mw@semihalf.com>
Cc: Gregory CLEMENT <gregory.clement@free-electrons.com>,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
arm@kernel.org, Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Jonathan Corbet <corbet@lwn.net>,
Mark Rutland <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
linux-ide@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Omri Itach <omrii@marvell.com>,
linux-kernel@vger.kernel.org, Nadav Haklai <nadavh@marvell.com>,
Hans de Goede <hdegoede@redhat.com>,
Lior Amsalem <alior@marvell.com>,
linux-serial@vger.kernel.org, Jiri Slaby <jslaby@suse.com>,
Tejun Heo <tj@kernel.org>, Wilson Ding <dingwei@marvell.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 03/12] serial: mvebu-uart: initial support for Armada-3700 serial port
Date: Wed, 3 Feb 2016 23:02:24 +0100 [thread overview]
Message-ID: <20160203230224.5ea52f65@free-electrons.com> (raw)
In-Reply-To: <CAPv3WKdh8D8GYMabALQQW-Z7L+=XhkZw2cXdYpcQ8tF0Rjckag@mail.gmail.com>
Dear Marcin Wojtas,
On Wed, 3 Feb 2016 22:41:15 +0100, Marcin Wojtas wrote:
> Hi Gregory,
>
> > + port->irq = irq->start;
> > + port->irqflags = 0;
>
> Same request as for v1, which you must have overlooked:
> port->irqflags = IRQF_SHARED;
Gregory didn't overlook this comment you made on v1, he even replied to
it. Please check Gregory's reply to your review.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 03/12] serial: mvebu-uart: initial support for Armada-3700 serial port
Date: Wed, 3 Feb 2016 23:02:24 +0100 [thread overview]
Message-ID: <20160203230224.5ea52f65@free-electrons.com> (raw)
In-Reply-To: <CAPv3WKdh8D8GYMabALQQW-Z7L+=XhkZw2cXdYpcQ8tF0Rjckag@mail.gmail.com>
Dear Marcin Wojtas,
On Wed, 3 Feb 2016 22:41:15 +0100, Marcin Wojtas wrote:
> Hi Gregory,
>
> > + port->irq = irq->start;
> > + port->irqflags = 0;
>
> Same request as for v1, which you must have overlooked:
> port->irqflags = IRQF_SHARED;
Gregory didn't overlook this comment you made on v1, he even replied to
it. Please check Gregory's reply to your review.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-02-03 22:02 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-03 18:41 [PATCH v2 00/12] Add support for the Armada 3700 SoC an mvebu ARM64 based Gregory CLEMENT
2016-02-03 18:41 ` Gregory CLEMENT
2016-02-03 18:41 ` [PATCH v2 01/12] irqchip: armada-370-xp: add Kconfig option for the driver Gregory CLEMENT
2016-02-03 18:41 ` Gregory CLEMENT
2016-02-03 18:41 ` [PATCH v2 02/12] irqchip: armada-370-xp: do not enable it by default when ARCH_MVEBU is selected Gregory CLEMENT
2016-02-03 18:41 ` Gregory CLEMENT
2016-02-03 18:41 ` [PATCH v2 03/12] serial: mvebu-uart: initial support for Armada-3700 serial port Gregory CLEMENT
2016-02-03 18:41 ` Gregory CLEMENT
2016-02-03 21:41 ` Marcin Wojtas
2016-02-03 21:41 ` Marcin Wojtas
2016-02-03 22:02 ` Thomas Petazzoni [this message]
2016-02-03 22:02 ` Thomas Petazzoni
2016-02-03 22:22 ` Marcin Wojtas
2016-02-03 22:22 ` Marcin Wojtas
2016-02-04 3:22 ` Ofer Heifetz
2016-02-04 3:22 ` Ofer Heifetz
2016-02-04 3:22 ` Ofer Heifetz
2016-02-07 7:17 ` Greg Kroah-Hartman
2016-02-07 7:17 ` Greg Kroah-Hartman
2016-02-07 11:16 ` Gregory CLEMENT
2016-02-07 11:16 ` Gregory CLEMENT
2016-02-03 18:41 ` [PATCH v2 04/12] ata: ahci_mvebu: add support for Armada 3700 variant Gregory CLEMENT
2016-02-03 18:41 ` Gregory CLEMENT
2016-02-03 18:41 ` [PATCH v2 05/12] arm64: add mvebu architecture entry Gregory CLEMENT
2016-02-03 18:41 ` Gregory CLEMENT
2016-02-03 18:41 ` [PATCH v2 06/12] Documentation: dt-bindings: Add a new compatible for the Armada 3700 Gregory CLEMENT
2016-02-03 18:41 ` Gregory CLEMENT
2016-02-03 18:41 ` [PATCH v2 07/12] Documentation: dt: Tidy up the Marvell related files Gregory CLEMENT
2016-02-03 18:41 ` Gregory CLEMENT
2016-02-03 18:41 ` [PATCH v2 08/12] devicetree: bindings: add DT binding for the Marvell Armada 3700 SoC family Gregory CLEMENT
2016-02-03 18:41 ` Gregory CLEMENT
2016-02-03 20:23 ` Rob Herring
2016-02-03 20:23 ` Rob Herring
2016-02-03 20:23 ` Rob Herring
2016-02-03 20:38 ` Thomas Petazzoni
2016-02-03 20:38 ` Thomas Petazzoni
[not found] ` <20160203213825.4fa6a0ef-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-02-05 16:03 ` Gregory CLEMENT
2016-02-05 16:03 ` Gregory CLEMENT
2016-02-05 16:03 ` Gregory CLEMENT
2016-02-03 18:41 ` [PATCH v2 09/12] arm64: dts: add the Marvell Armada 3700 family and a development board Gregory CLEMENT
2016-02-03 18:41 ` Gregory CLEMENT
2016-02-03 18:41 ` [PATCH v2 10/12] MAINTAINERS: Extend dts entry for ARM64 mvebu files Gregory CLEMENT
2016-02-03 18:41 ` Gregory CLEMENT
2016-02-03 18:41 ` [PATCH v2 11/12] Documentation: arm: update supported Marvell EBU processors Gregory CLEMENT
2016-02-03 18:41 ` Gregory CLEMENT
2016-02-03 18:41 ` [PATCH v2 12/12] arm64: defconfig: enable Armada 3700 related config Gregory CLEMENT
2016-02-03 18:41 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160203230224.5ea52f65@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=alior@marvell.com \
--cc=andrew@lunn.ch \
--cc=arm@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=dingwei@marvell.com \
--cc=gregkh@linuxfoundation.org \
--cc=gregory.clement@free-electrons.com \
--cc=hdegoede@redhat.com \
--cc=jason@lakedaemon.net \
--cc=jslaby@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=omrii@marvell.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tj@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.