* [PATCH] toaster: reinstate ID on edit columns button
@ 2016-02-04 9:26 Ed Bartosh
2016-02-04 9:29 ` Ed Bartosh
0 siblings, 1 reply; 2+ messages in thread
From: Ed Bartosh @ 2016-02-04 9:26 UTC (permalink / raw)
To: bitbake-devel
From: Elliot Smith <elliot.smith@intel.com>
The ID was omitted from the "edit columns" button on the
"projects", "all builds" and "project builds" tables when they
were converted to ToasterTable. This caused the QA tests to fail.
Reinstate the ID so the tests can identify the "edit columns" button
correctly.
[YOCTO #9051]
Signed-off-by: Elliot Smith <elliot.smith@intel.com>
Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
---
bitbake/lib/toaster/toastergui/templates/toastertable.html | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bitbake/lib/toaster/toastergui/templates/toastertable.html b/bitbake/lib/toaster/toastergui/templates/toastertable.html
index f0a3aed..9099b30 100644
--- a/bitbake/lib/toaster/toastergui/templates/toastertable.html
+++ b/bitbake/lib/toaster/toastergui/templates/toastertable.html
@@ -57,7 +57,7 @@
<div class="pull-right">
<div class="btn-group">
- <button class="btn dropdown-toggle" data-toggle="dropdown">Edit columns
+ <button id="edit-columns-button" class="btn dropdown-toggle" data-toggle="dropdown">Edit columns
<span class="caret"></span>
</button>
<ul class="dropdown-menu editcol">
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] toaster: reinstate ID on edit columns button
2016-02-04 9:26 [PATCH] toaster: reinstate ID on edit columns button Ed Bartosh
@ 2016-02-04 9:29 ` Ed Bartosh
0 siblings, 0 replies; 2+ messages in thread
From: Ed Bartosh @ 2016-02-04 9:29 UTC (permalink / raw)
To: bitbake-devel
Looks good to me.
Sent upstream.
On Thu, Feb 04, 2016 at 11:26:20AM +0200, Ed Bartosh wrote:
> From: Elliot Smith <elliot.smith@intel.com>
>
> The ID was omitted from the "edit columns" button on the
> "projects", "all builds" and "project builds" tables when they
> were converted to ToasterTable. This caused the QA tests to fail.
>
> Reinstate the ID so the tests can identify the "edit columns" button
> correctly.
>
> [YOCTO #9051]
>
> Signed-off-by: Elliot Smith <elliot.smith@intel.com>
> Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
> ---
> bitbake/lib/toaster/toastergui/templates/toastertable.html | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/bitbake/lib/toaster/toastergui/templates/toastertable.html b/bitbake/lib/toaster/toastergui/templates/toastertable.html
> index f0a3aed..9099b30 100644
> --- a/bitbake/lib/toaster/toastergui/templates/toastertable.html
> +++ b/bitbake/lib/toaster/toastergui/templates/toastertable.html
> @@ -57,7 +57,7 @@
>
> <div class="pull-right">
> <div class="btn-group">
> - <button class="btn dropdown-toggle" data-toggle="dropdown">Edit columns
> + <button id="edit-columns-button" class="btn dropdown-toggle" data-toggle="dropdown">Edit columns
> <span class="caret"></span>
> </button>
> <ul class="dropdown-menu editcol">
> --
> 2.1.4
>
--
--
Regards,
Ed
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-04 11:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-04 9:26 [PATCH] toaster: reinstate ID on edit columns button Ed Bartosh
2016-02-04 9:29 ` Ed Bartosh
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.