From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
lgirdwood@gmail.com
Subject: Re: [PATCH] ASoC: arizona: Add support for SNDRV_PCM_RATE_KNOT
Date: Thu, 4 Feb 2016 12:46:44 +0000 [thread overview]
Message-ID: <20160204124644.GW1490@localhost.localdomain> (raw)
In-Reply-To: <20160202193002.GV4455@sirena.org.uk>
On Tue, Feb 02, 2016 at 07:30:02PM +0000, Mark Brown wrote:
> On Tue, Feb 02, 2016 at 04:38:04PM +0000, Charles Keepax wrote:
>
> > +#define ARIZONA_48K_RATES 12000, 24000, 48000, 96000, 192000, 4000, 8000, \
> > + 16000, 32000
>
> This just looks wrong. It's valid code but with the combination of the
> split line and the list without any sort of parenthesis it sets off
> alarm bells. Duplicating might not be the worst thing ever...
I will respin with just duplicating the rates lists, I am happy
enough with that.
Thanks,
Charles
prev parent reply other threads:[~2016-02-04 12:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 16:38 [PATCH] ASoC: arizona: Add support for SNDRV_PCM_RATE_KNOT Charles Keepax
2016-02-02 19:30 ` Mark Brown
2016-02-03 8:24 ` Lars-Peter Clausen
2016-02-03 9:41 ` Charles Keepax
2016-02-04 12:45 ` Charles Keepax
2016-02-04 12:55 ` Lars-Peter Clausen
2016-02-04 14:34 ` Charles Keepax
2016-02-04 12:46 ` Charles Keepax [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160204124644.GW1490@localhost.localdomain \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.