From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@kernel.org>,
Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
lgirdwood@gmail.com
Subject: Re: [PATCH] ASoC: arizona: Add support for SNDRV_PCM_RATE_KNOT
Date: Wed, 3 Feb 2016 09:24:25 +0100 [thread overview]
Message-ID: <56B1B939.5030503@metafoo.de> (raw)
In-Reply-To: <20160202193002.GV4455@sirena.org.uk>
[-- Attachment #1.1: Type: text/plain, Size: 668 bytes --]
On 02/02/2016 08:30 PM, Mark Brown wrote:
> On Tue, Feb 02, 2016 at 04:38:04PM +0000, Charles Keepax wrote:
>
>> +#define ARIZONA_48K_RATES 12000, 24000, 48000, 96000, 192000, 4000, 8000, \
>> + 16000, 32000
>
> This just looks wrong. It's valid code but with the combination of the
> split line and the list without any sort of parenthesis it sets off
> alarm bells. Duplicating might not be the worst thing ever...
For list constraints it is possible to specify a mask for which of the
entries in the rates array should be considered. So you could use the same
rate array, but use different masks. The adau1977 drive for example does this.
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2016-02-03 8:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 16:38 [PATCH] ASoC: arizona: Add support for SNDRV_PCM_RATE_KNOT Charles Keepax
2016-02-02 19:30 ` Mark Brown
2016-02-03 8:24 ` Lars-Peter Clausen [this message]
2016-02-03 9:41 ` Charles Keepax
2016-02-04 12:45 ` Charles Keepax
2016-02-04 12:55 ` Lars-Peter Clausen
2016-02-04 14:34 ` Charles Keepax
2016-02-04 12:46 ` Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B1B939.5030503@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=lgirdwood@gmail.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.