From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] migration: move page_cache.c to migration/
Date: Thu, 4 Feb 2016 15:27:50 +0000 [thread overview]
Message-ID: <20160204152749.GE2427@work-vm> (raw)
In-Reply-To: <1454583838-22272-1-git-send-email-pbonzini@redhat.com>
* Paolo Bonzini (pbonzini@redhat.com) wrote:
> page_cache.c is part of the XBZRLE implementation, move it to the right
> directory.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Does that need tests/Makefile updating - I see:
tests/test-xbzrle$(EXESUF): tests/test-xbzrle.o migration/xbzrle.o page_cache.o $(test-util-obj-y)
I'm OK with moving this, although I didn't when I moved everything
else because there's nothing stopping anyone using it outside of migration.
Dave
> ---
> Makefile.objs | 1 -
> migration/Makefile.objs | 2 +-
> page_cache.c => migration/page_cache.c | 0
> 3 files changed, 1 insertion(+), 2 deletions(-)
> rename page_cache.c => migration/page_cache.c (100%)
>
> diff --git a/Makefile.objs b/Makefile.objs
> index 06b95c7..f950b0f 100644
> --- a/Makefile.objs
> +++ b/Makefile.objs
> @@ -51,7 +51,6 @@ common-obj-$(CONFIG_LINUX) += fsdev/
>
> common-obj-y += migration/
> common-obj-y += qemu-char.o #aio.o
> -common-obj-y += page_cache.o
> common-obj-y += qjson.o
>
> common-obj-$(CONFIG_SPICE) += spice-qemu-char.o
> diff --git a/migration/Makefile.objs b/migration/Makefile.objs
> index 0cac6d7..e5778de 100644
> --- a/migration/Makefile.objs
> +++ b/migration/Makefile.objs
> @@ -1,7 +1,7 @@
> common-obj-y += migration.o tcp.o
> common-obj-y += vmstate.o
> common-obj-y += qemu-file.o qemu-file-buf.o qemu-file-unix.o qemu-file-stdio.o
> -common-obj-y += xbzrle.o postcopy-ram.o
> +common-obj-y += xbzrle.o page_cache.o postcopy-ram.o
>
> common-obj-$(CONFIG_RDMA) += rdma.o
> common-obj-$(CONFIG_POSIX) += exec.o unix.o fd.o
> diff --git a/page_cache.c b/migration/page_cache.c
> similarity index 100%
> rename from page_cache.c
> rename to migration/page_cache.c
> --
> 2.5.0
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
WARNING: multiple messages have this Message-ID (diff)
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] migration: move page_cache.c to migration/
Date: Thu, 4 Feb 2016 15:27:50 +0000 [thread overview]
Message-ID: <20160204152749.GE2427@work-vm> (raw)
In-Reply-To: <1454583838-22272-1-git-send-email-pbonzini@redhat.com>
* Paolo Bonzini (pbonzini@redhat.com) wrote:
> page_cache.c is part of the XBZRLE implementation, move it to the right
> directory.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Does that need tests/Makefile updating - I see:
tests/test-xbzrle$(EXESUF): tests/test-xbzrle.o migration/xbzrle.o page_cache.o $(test-util-obj-y)
I'm OK with moving this, although I didn't when I moved everything
else because there's nothing stopping anyone using it outside of migration.
Dave
> ---
> Makefile.objs | 1 -
> migration/Makefile.objs | 2 +-
> page_cache.c => migration/page_cache.c | 0
> 3 files changed, 1 insertion(+), 2 deletions(-)
> rename page_cache.c => migration/page_cache.c (100%)
>
> diff --git a/Makefile.objs b/Makefile.objs
> index 06b95c7..f950b0f 100644
> --- a/Makefile.objs
> +++ b/Makefile.objs
> @@ -51,7 +51,6 @@ common-obj-$(CONFIG_LINUX) += fsdev/
>
> common-obj-y += migration/
> common-obj-y += qemu-char.o #aio.o
> -common-obj-y += page_cache.o
> common-obj-y += qjson.o
>
> common-obj-$(CONFIG_SPICE) += spice-qemu-char.o
> diff --git a/migration/Makefile.objs b/migration/Makefile.objs
> index 0cac6d7..e5778de 100644
> --- a/migration/Makefile.objs
> +++ b/migration/Makefile.objs
> @@ -1,7 +1,7 @@
> common-obj-y += migration.o tcp.o
> common-obj-y += vmstate.o
> common-obj-y += qemu-file.o qemu-file-buf.o qemu-file-unix.o qemu-file-stdio.o
> -common-obj-y += xbzrle.o postcopy-ram.o
> +common-obj-y += xbzrle.o page_cache.o postcopy-ram.o
>
> common-obj-$(CONFIG_RDMA) += rdma.o
> common-obj-$(CONFIG_POSIX) += exec.o unix.o fd.o
> diff --git a/page_cache.c b/migration/page_cache.c
> similarity index 100%
> rename from page_cache.c
> rename to migration/page_cache.c
> --
> 2.5.0
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2016-02-04 15:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-04 11:03 [Qemu-trivial] [PATCH] migration: move page_cache.c to migration/ Paolo Bonzini
2016-02-04 11:03 ` [Qemu-devel] " Paolo Bonzini
2016-02-04 15:27 ` Dr. David Alan Gilbert [this message]
2016-02-04 15:27 ` Dr. David Alan Gilbert
2016-02-04 16:01 ` [Qemu-trivial] " Paolo Bonzini
2016-02-04 16:01 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160204152749.GE2427@work-vm \
--to=dgilbert@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.