All of lore.kernel.org
 help / color / mirror / Atom feed
From: robh@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 01/11] drm/hisilicon: Add device tree binding for hi6220 display subsystem
Date: Mon, 8 Feb 2016 14:12:46 -0600	[thread overview]
Message-ID: <20160208201246.GA17459@rob-hp-laptop> (raw)
In-Reply-To: <1454729098-79807-2-git-send-email-xinliang.liu@linaro.org>

On Sat, Feb 06, 2016 at 11:24:48AM +0800, Xinliang Liu wrote:
> Add ADE display controller binding doc.
> Add DesignWare DSI Host Controller v1.20a binding doc.

One comment, otherwise:

Acked-by: Rob Herring <robh@kernel.org>

> +Board specific:
> +	&dsi {
> +		status = "ok";
> +
> +		ports {
> +			/* 1 for output port */
> +			port at 1 {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +				reg = <1>;
> +
> +				/* 0 for bridge, other value for panel */

The endpoint address would not change based on bridge or panel. So you 
can drop the unit address here.

> +				dsi_out0: endpoint at 0 {
> +					reg = <0>;
> +					remote-endpoint = <&adv7533_in>;
> +				};
> +			};
> +		};
> +	};

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Xinliang Liu <xinliang.liu@linaro.org>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	daniel@ffwll.ch, daniel@fooishbar.org, architt@codeaurora.org,
	airlied@linux.ie, corbet@lwn.net, catalin.marinas@arm.com,
	will.deacon@arm.com, emil.l.velikov@gmail.com,
	linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linuxarm@huawei.com, andy.green@linaro.org,
	haojian.zhuang@linaro.org, liguozhu@hisilicon.com,
	xuwei5@hisilicon.com, w.f@huawei.com, puck.chen@hisilicon.com,
	bintian.wang@huawei.com, benjamin.gaignard@linaro.org,
	xuyiping@hisilicon.com, kong.kongxinwei@hisilicon.com,
	zourongrong@huawei.com, lijianhua@huawei.com,
	sumit.semwal@linaro.org, guodong.xu@linaro.org
Subject: Re: [PATCH v4 01/11] drm/hisilicon: Add device tree binding for hi6220 display subsystem
Date: Mon, 8 Feb 2016 14:12:46 -0600	[thread overview]
Message-ID: <20160208201246.GA17459@rob-hp-laptop> (raw)
In-Reply-To: <1454729098-79807-2-git-send-email-xinliang.liu@linaro.org>

On Sat, Feb 06, 2016 at 11:24:48AM +0800, Xinliang Liu wrote:
> Add ADE display controller binding doc.
> Add DesignWare DSI Host Controller v1.20a binding doc.

One comment, otherwise:

Acked-by: Rob Herring <robh@kernel.org>

> +Board specific:
> +	&dsi {
> +		status = "ok";
> +
> +		ports {
> +			/* 1 for output port */
> +			port@1 {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +				reg = <1>;
> +
> +				/* 0 for bridge, other value for panel */

The endpoint address would not change based on bridge or panel. So you 
can drop the unit address here.

> +				dsi_out0: endpoint@0 {
> +					reg = <0>;
> +					remote-endpoint = <&adv7533_in>;
> +				};
> +			};
> +		};
> +	};

  parent reply	other threads:[~2016-02-08 20:12 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-06  3:24 [PATCH v4 00/11] Add DRM Driver for HiSilicon Kirin hi6220 SoC Xinliang Liu
2016-02-06  3:24 ` Xinliang Liu
2016-02-06  3:24 ` [PATCH v4 01/11] drm/hisilicon: Add device tree binding for hi6220 display subsystem Xinliang Liu
2016-02-06  3:24   ` Xinliang Liu
2016-02-08 10:43   ` Archit Taneja
2016-02-08 10:43     ` Archit Taneja
2016-02-17 11:46     ` Xinliang Liu
2016-02-17 11:46       ` Xinliang Liu
2016-02-08 20:12   ` Rob Herring [this message]
2016-02-08 20:12     ` Rob Herring
2016-02-15  7:30     ` Xinliang Liu
2016-02-15  7:30       ` Xinliang Liu
2016-02-06  3:24 ` [PATCH v4 02/11] drm/hisilicon: Add hisilicon kirin drm master driver Xinliang Liu
2016-02-06  3:24   ` Xinliang Liu
2016-02-06  3:24 ` [PATCH v4 03/11] drm/hisilicon: Add crtc driver for ADE Xinliang Liu
2016-02-06  3:24   ` Xinliang Liu
2016-02-08 10:59   ` Archit Taneja
2016-02-08 10:59     ` Archit Taneja
2016-02-17 11:40     ` Xinliang Liu
2016-02-17 11:40       ` Xinliang Liu
2016-02-06  3:24 ` [PATCH v4 04/11] drm/hisilicon: Add plane " Xinliang Liu
2016-02-06  3:24   ` Xinliang Liu
2016-02-06  3:24 ` [PATCH v4 05/11] drm/hisilicon: Add vblank " Xinliang Liu
2016-02-06  3:24   ` Xinliang Liu
2016-02-06  3:24 ` [PATCH v4 06/11] drm/hisilicon: Add cma fbdev and hotplug Xinliang Liu
2016-02-06  3:24   ` Xinliang Liu
2016-02-06  3:24 ` [PATCH v4 07/11] drm/hisilicon: Add designware dsi encoder driver Xinliang Liu
2016-02-06  3:24   ` Xinliang Liu
2016-02-06  3:24 ` [PATCH v4 08/11] drm/hisilicon: Add designware dsi host driver Xinliang Liu
2016-02-06  3:24   ` Xinliang Liu
2016-02-06  3:24 ` [PATCH v4 09/11] drm/hisilicon: Add support for external bridge Xinliang Liu
2016-02-06  3:24   ` Xinliang Liu
2016-02-06  3:24 ` [PATCH v4 10/11] MAINTAINERS: Add maintainer for hisilicon DRM driver Xinliang Liu
2016-02-06  3:24   ` Xinliang Liu
2016-02-06  3:24 ` [PATCH v4 11/11] arm64: dts: hisilicon: Add display subsystem DT nodes for hi6220 Xinliang Liu
2016-02-06  3:24   ` Xinliang Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160208201246.GA17459@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.