From: Tony Lindgren <tony@atomide.com>
To: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
Cc: rogerq@ti.com, khilman@deeprootsystems.com,
linux@arm.linux.org.uk, pali.rohar@gmail.com, sre@kernel.org,
aaro.koskinen@iki.fi, pavel@ucw.cz, nm@ti.com,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: OMAP2+: Fix onenand initialization to avoid filesystem corruption
Date: Mon, 8 Feb 2016 12:26:46 -0800 [thread overview]
Message-ID: <20160208202646.GA19432@atomide.com> (raw)
In-Reply-To: <56B8F71A.7090102@gmail.com>
* Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> [160208 12:15]:
> Hi
>
> On 8.02.2016 21:36, Tony Lindgren wrote:
> >
> >OK. So probably the INT or RDY polarity made the ECC not work.
> >
>
> Well, ECC disable bit (ONENAND_SYS_CFG1_NO_ECC) was set as well, so most
> probably it was the bugger :)
Oh OK that explains.
> >Aaro, care to dump out also the nolo configured CFG1 value from
> >n8x0 and n9(50)?
> >
> >You can do it by adding something like this to the beginning
> >of set_onenand_cfg():
> >
>
> Also, do not forget to restore HWMOD_INIT_NO_RESET in gpmc_hwmod in question
> and (maybe) revert e7b11dc7b77bfce0a351230a5feeadc1d0bba997.
Probably just enabling CONFIG_OMAP_GPMC_DEBUG allows dumping
the GPMC configuration. And it sounds like it's a good idea
to have this patch enabled.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP2+: Fix onenand initialization to avoid filesystem corruption
Date: Mon, 8 Feb 2016 12:26:46 -0800 [thread overview]
Message-ID: <20160208202646.GA19432@atomide.com> (raw)
In-Reply-To: <56B8F71A.7090102@gmail.com>
* Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> [160208 12:15]:
> Hi
>
> On 8.02.2016 21:36, Tony Lindgren wrote:
> >
> >OK. So probably the INT or RDY polarity made the ECC not work.
> >
>
> Well, ECC disable bit (ONENAND_SYS_CFG1_NO_ECC) was set as well, so most
> probably it was the bugger :)
Oh OK that explains.
> >Aaro, care to dump out also the nolo configured CFG1 value from
> >n8x0 and n9(50)?
> >
> >You can do it by adding something like this to the beginning
> >of set_onenand_cfg():
> >
>
> Also, do not forget to restore HWMOD_INIT_NO_RESET in gpmc_hwmod in question
> and (maybe) revert e7b11dc7b77bfce0a351230a5feeadc1d0bba997.
Probably just enabling CONFIG_OMAP_GPMC_DEBUG allows dumping
the GPMC configuration. And it sounds like it's a good idea
to have this patch enabled.
Regards,
Tony
next prev parent reply other threads:[~2016-02-08 20:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 14:37 [PATCH] ARM: OMAP2+: Fix onenand initialization to avoid filesystem corruption Ivaylo Dimitrov
2016-02-05 14:37 ` Ivaylo Dimitrov
2016-02-08 19:36 ` Tony Lindgren
2016-02-08 19:36 ` Tony Lindgren
2016-02-08 20:14 ` Ivaylo Dimitrov
2016-02-08 20:14 ` Ivaylo Dimitrov
2016-02-08 20:26 ` Tony Lindgren [this message]
2016-02-08 20:26 ` Tony Lindgren
2016-02-10 21:12 ` Aaro Koskinen
2016-02-10 21:12 ` Aaro Koskinen
2016-02-11 0:12 ` Tony Lindgren
2016-02-11 0:12 ` Tony Lindgren
2016-02-21 18:13 ` Ivaylo Dimitrov
2016-02-21 18:13 ` Ivaylo Dimitrov
2016-02-22 16:09 ` Tony Lindgren
2016-02-22 16:09 ` Tony Lindgren
2016-02-21 18:44 ` Aaro Koskinen
2016-02-21 18:44 ` Aaro Koskinen
[not found] <linux-kernel@vger.kernel.org>
2026-02-06 19:26 ` [PATCH] crypto: tesmgr - allow authenc(hmac(sha224/sha384),cbc(aes)) in fips mode Aleksander Jan Bajkowski
2026-02-28 8:41 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160208202646.GA19432@atomide.com \
--to=tony@atomide.com \
--cc=aaro.koskinen@iki.fi \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=nm@ti.com \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
--cc=rogerq@ti.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.