From: Stephen Boyd <sboyd@codeaurora.org>
To: Matthew McClintock <mmcclint@qca.qualcomm.com>
Cc: Andy Gross <agross@codeaurora.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Matthew McClintock <mmcclint@codeaurora.org>,
linux-kernel@vger.kernel.org,
qca-upstream.external@qca.qualcomm.com,
Senthilkumar N L <snlakshm@codeaurora.org>,
Varadarajan Narayanan <varada@codeaurora.org>
Subject: Re: [PATCH v3 5/6] dts: ipq4019: Add support for IPQ4019 DK01 board
Date: Mon, 8 Feb 2016 14:43:28 -0800 [thread overview]
Message-ID: <20160208224328.GB10791@codeaurora.org> (raw)
In-Reply-To: <1447975173-29485-6-git-send-email-mmcclint@qca.qualcomm.com>
On 11/19, Matthew McClintock wrote:
> +
> +/ {
> + model = "Qualcomm Technologies, Inc. IPQ4019/AP-DK01.1";
> + compatible = "qcom,ipq4019";
> +
> + clocks {
> + xo: xo {
> + compatible = "fixed-clock";
> + clock-frequency = <48000000>;
> + #clock-cells = <0>;
> + };
> + };
Is there a reason the xo is here and the sleep clk is in the SoC
dtsi file? Both are board clocks so I would think they would be
added in the same place.
> +
> + soc {
> +
> +
> + timer {
> + compatible = "arm,armv7-timer";
> + interrupts = <1 2 0xf08>,
> + <1 3 0xf08>,
> + <1 4 0xf08>,
> + <1 1 0xf08>;
> + clock-frequency = <48000000>;
> + };
The timer shouldn't be part of the SoC node (it has no reg property).
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 5/6] dts: ipq4019: Add support for IPQ4019 DK01 board
Date: Mon, 8 Feb 2016 14:43:28 -0800 [thread overview]
Message-ID: <20160208224328.GB10791@codeaurora.org> (raw)
In-Reply-To: <1447975173-29485-6-git-send-email-mmcclint@qca.qualcomm.com>
On 11/19, Matthew McClintock wrote:
> +
> +/ {
> + model = "Qualcomm Technologies, Inc. IPQ4019/AP-DK01.1";
> + compatible = "qcom,ipq4019";
> +
> + clocks {
> + xo: xo {
> + compatible = "fixed-clock";
> + clock-frequency = <48000000>;
> + #clock-cells = <0>;
> + };
> + };
Is there a reason the xo is here and the sleep clk is in the SoC
dtsi file? Both are board clocks so I would think they would be
added in the same place.
> +
> + soc {
> +
> +
> + timer {
> + compatible = "arm,armv7-timer";
> + interrupts = <1 2 0xf08>,
> + <1 3 0xf08>,
> + <1 4 0xf08>,
> + <1 1 0xf08>;
> + clock-frequency = <48000000>;
> + };
The timer shouldn't be part of the SoC node (it has no reg property).
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-02-08 22:43 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-19 23:19 [PATCH v3 0/6] arm: qcom: Add support for IPQ8014 family of SoCs Matthew McClintock
2015-11-19 23:19 ` [PATCH v3 1/6] pinctrl: qcom: ipq4019: Add IPQ4019 pinctrl support Matthew McClintock
2015-11-20 16:35 ` Rob Herring
2015-12-11 4:03 ` [v3,1/6] " Andy Gross
2016-02-15 0:41 ` [PATCH v3 1/6] " Bjorn Andersson
2016-02-16 14:53 ` Linus Walleij
2016-02-16 14:54 ` Linus Walleij
2016-02-16 16:31 ` Matthew McClintock
2016-02-16 16:31 ` Matthew McClintock
2015-11-19 23:19 ` [PATCH v3 2/6] clk: qcom: Add IPQ4019 Global Clock Controller support Matthew McClintock
2015-12-11 4:06 ` [v3,2/6] " Andy Gross
2016-02-25 22:33 ` [PATCH v3 2/6] " Stephen Boyd
2015-11-19 23:19 ` [PATCH v3 3/6] ARM: qcom: add IPQ4019 compatible match Matthew McClintock
2016-02-08 22:46 ` Stephen Boyd
2015-11-19 23:19 ` [PATCH v3 4/6] qcom: ipq4019: Add basic board/dts support for IPQ4019 SoC Matthew McClintock
2015-11-19 23:19 ` Matthew McClintock
2015-11-19 23:19 ` Matthew McClintock
2016-02-08 22:45 ` Stephen Boyd
2016-02-08 22:45 ` Stephen Boyd
2015-11-19 23:19 ` [PATCH v3 5/6] dts: ipq4019: Add support for IPQ4019 DK01 board Matthew McClintock
2015-11-19 23:19 ` Matthew McClintock
2016-02-08 22:43 ` Stephen Boyd [this message]
2016-02-08 22:43 ` Stephen Boyd
2016-02-16 20:43 ` Matthew McClintock
2016-02-16 20:43 ` Matthew McClintock
2016-02-16 20:43 ` Matthew McClintock
[not found] ` <59152C1B-683F-417D-9C23-C6E3F53D7096-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-02-19 2:43 ` Stephen Boyd
2016-02-19 2:43 ` Stephen Boyd
2016-02-19 2:43 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160208224328.GB10791@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=agross@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmcclint@codeaurora.org \
--cc=mmcclint@qca.qualcomm.com \
--cc=qca-upstream.external@qca.qualcomm.com \
--cc=snlakshm@codeaurora.org \
--cc=varada@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.