All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: "Michel Dänzer" <michel@daenzer.net>
Cc: Peter Hurley <peter@hurleysoftware.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Linux kernel <linux-kernel@vger.kernel.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	Ben Skeggs <bskeggs@redhat.com>
Subject: Re: BUG caused by "Use new drm_fb_helper functions" series
Date: Tue, 9 Feb 2016 10:32:40 +0100	[thread overview]
Message-ID: <20160209093240.GF11240@phenom.ffwll.local> (raw)
In-Reply-To: <56B1C8CE.1090607@daenzer.net>

On Wed, Feb 03, 2016 at 06:30:54PM +0900, Michel Dänzer wrote:
> On 03.02.2016 03:38, Peter Hurley wrote:
> > On 02/01/2016 09:20 PM, Archit Taneja wrote:
> >> Hi Peter,
> >>
> >> On 02/02/2016 02:07 AM, Peter Hurley wrote:
> >>> Hi Archit,
> >>>
> >>> Just booting 4.4-rc5+, I got this splat [1]
> >>> At first glance, this appears to be a simple fix.
> >>
> >> Thanks for sharing this.
> >>
> >>>
> >>> However, I'm concerned that fbcon functions, which may be called with
> >>> interrupts disabled, are now hooked up to fbdev functions which may assume
> >>> interrupts are not disabled (as is the case with cfb_imageblit()).
> >>
> >> In the case when CONFIG_FB is enabled, drm_fb_helper_cfb_imageblit
> >> helper simply wraps around cfg_imageblit, so I don't see how we'd have
> >> any difference in behaviour.
> > 
> > 
> > Sorry; terrible attribution on my part.
> > This bug clearly has nothing to do with this series.
> > 
> > But a better look has me wondering how all these gpus are syncing
> > the framebuffer for direct access via cfb_imageblit and friends. I only see
> > nouveau and intel gma even trying.
> 
> Probably no other DRM driver uses hardware acceleration for fbcon.

Yup. We've had patches for i915, resulted in half of mesa+glamour in-kernel, which
is just pointless.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: "Michel Dänzer" <michel@daenzer.net>
Cc: Peter Hurley <peter@hurleysoftware.com>,
	Archit Taneja <architt@codeaurora.org>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Ben Skeggs <bskeggs@redhat.com>,
	Linux kernel <linux-kernel@vger.kernel.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>
Subject: Re: BUG caused by "Use new drm_fb_helper functions" series
Date: Tue, 9 Feb 2016 10:32:40 +0100	[thread overview]
Message-ID: <20160209093240.GF11240@phenom.ffwll.local> (raw)
In-Reply-To: <56B1C8CE.1090607@daenzer.net>

On Wed, Feb 03, 2016 at 06:30:54PM +0900, Michel Dänzer wrote:
> On 03.02.2016 03:38, Peter Hurley wrote:
> > On 02/01/2016 09:20 PM, Archit Taneja wrote:
> >> Hi Peter,
> >>
> >> On 02/02/2016 02:07 AM, Peter Hurley wrote:
> >>> Hi Archit,
> >>>
> >>> Just booting 4.4-rc5+, I got this splat [1]
> >>> At first glance, this appears to be a simple fix.
> >>
> >> Thanks for sharing this.
> >>
> >>>
> >>> However, I'm concerned that fbcon functions, which may be called with
> >>> interrupts disabled, are now hooked up to fbdev functions which may assume
> >>> interrupts are not disabled (as is the case with cfb_imageblit()).
> >>
> >> In the case when CONFIG_FB is enabled, drm_fb_helper_cfb_imageblit
> >> helper simply wraps around cfg_imageblit, so I don't see how we'd have
> >> any difference in behaviour.
> > 
> > 
> > Sorry; terrible attribution on my part.
> > This bug clearly has nothing to do with this series.
> > 
> > But a better look has me wondering how all these gpus are syncing
> > the framebuffer for direct access via cfb_imageblit and friends. I only see
> > nouveau and intel gma even trying.
> 
> Probably no other DRM driver uses hardware acceleration for fbcon.

Yup. We've had patches for i915, resulted in half of mesa+glamour in-kernel, which
is just pointless.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

  reply	other threads:[~2016-02-09  9:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-01 20:37 BUG caused by "Use new drm_fb_helper functions" series Peter Hurley
2016-02-01 20:37 ` Peter Hurley
2016-02-02  5:20 ` Archit Taneja
2016-02-02  5:20   ` Archit Taneja
2016-02-02 18:38   ` Peter Hurley
2016-02-02 18:38     ` Peter Hurley
2016-02-03  9:30     ` Michel Dänzer
2016-02-03  9:30       ` Michel Dänzer
2016-02-09  9:32       ` Daniel Vetter [this message]
2016-02-09  9:32         ` Daniel Vetter
2016-02-09 13:44         ` One Thousand Gnomes
2016-02-09 13:44           ` One Thousand Gnomes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160209093240.GF11240@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=bskeggs@redhat.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michel@daenzer.net \
    --cc=peter@hurleysoftware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.