[PATCH] Staging: rts5208: fix check for dma mapping error

[PATCH] Staging: rts5208: fix check for dma mapping error

[Haneen Mohammed]

use dma_mapping_error() instead of comparing the returned address with
zero after dma_map_single().

Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
---
 drivers/staging/rts5208/rtsx_transport.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rts5208/rtsx_transport.c b/drivers/staging/rts5208/rtsx_transport.c
index f27491e..0c9549b 100644
--- a/drivers/staging/rts5208/rtsx_transport.c
+++ b/drivers/staging/rts5208/rtsx_transport.c
@@ -653,7 +653,7 @@ static int rtsx_transfer_buf(struct rtsx_chip *chip, u8 card, void *buf,
 		return -ENXIO;
 
 	addr = dma_map_single(&(rtsx->pci->dev), buf, len, dma_dir);
-	if (!addr)
+	if (dma_mapping_error(&rtsx->pci->dev, addr))
 		return -ENOMEM;
 
 	if (card == SD_CARD)
-- 
1.9.1

Re: [Outreachy kernel] [PATCH] Staging: rts5208: fix check for dma mapping error

[Julia Lawall]

On Tue, 9 Feb 2016, Haneen Mohammed wrote:

> use dma_mapping_error() instead of comparing the returned address with
> zero after dma_map_single().

Acked-by: Julia Lawall <julia.lawall@lip6.fr>

However, the parentheses in &(rtsx->pci->dev) are really unpleasant.
Especially since they make the call to dma_map_single different from the
call to dma_mapping_error.

Maybe you could send a patch series to also get rid of them?

julia

>
> Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
> ---
>  drivers/staging/rts5208/rtsx_transport.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rts5208/rtsx_transport.c b/drivers/staging/rts5208/rtsx_transport.c
> index f27491e..0c9549b 100644
> --- a/drivers/staging/rts5208/rtsx_transport.c
> +++ b/drivers/staging/rts5208/rtsx_transport.c
> @@ -653,7 +653,7 @@ static int rtsx_transfer_buf(struct rtsx_chip *chip, u8 card, void *buf,
>  		return -ENXIO;
>
>  	addr = dma_map_single(&(rtsx->pci->dev), buf, len, dma_dir);
> -	if (!addr)
> +	if (dma_mapping_error(&rtsx->pci->dev, addr))
>  		return -ENOMEM;
>
>  	if (card == SD_CARD)
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160209103540.GA27735%40haneenVB.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH] Staging: rts5208: fix check for dma mapping error

[Haneen Mohammed]

On Tue, Feb 09, 2016 at 11:50:58AM +0100, Julia Lawall wrote:
> 
> 
> On Tue, 9 Feb 2016, Haneen Mohammed wrote:
> 
> > use dma_mapping_error() instead of comparing the returned address with
> > zero after dma_map_single().
> 
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> 
> However, the parentheses in &(rtsx->pci->dev) are really unpleasant.
> Especially since they make the call to dma_map_single different from the
> call to dma_mapping_error.
> 
> Maybe you could send a patch series to also get rid of them?
> 
> julia
> 
Sure. should I send it as v2? Also, I noticed in the discussion in the
previous thread about keeping the acked, yet I'm not sure how to do it.
could yo advise me on that please?

Thank you,
Haneen
> >
> > Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
> > ---
> >  drivers/staging/rts5208/rtsx_transport.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/rts5208/rtsx_transport.c b/drivers/staging/rts5208/rtsx_transport.c
> > index f27491e..0c9549b 100644
> > --- a/drivers/staging/rts5208/rtsx_transport.c
> > +++ b/drivers/staging/rts5208/rtsx_transport.c
> > @@ -653,7 +653,7 @@ static int rtsx_transfer_buf(struct rtsx_chip *chip, u8 card, void *buf,
> >  		return -ENXIO;
> >
> >  	addr = dma_map_single(&(rtsx->pci->dev), buf, len, dma_dir);
> > -	if (!addr)
> > +	if (dma_mapping_error(&rtsx->pci->dev, addr))
> >  		return -ENOMEM;
> >
> >  	if (card == SD_CARD)
> > --
> > 1.9.1
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160209103540.GA27735%40haneenVB.
> > For more options, visit https://groups.google.com/d/optout.
> >

Re: [Outreachy kernel] [PATCH] Staging: rts5208: fix check for dma mapping error

[Julia Lawall]

On Tue, 9 Feb 2016, Haneen Mohammed wrote:

> On Tue, Feb 09, 2016 at 11:50:58AM +0100, Julia Lawall wrote:
> >
> >
> > On Tue, 9 Feb 2016, Haneen Mohammed wrote:
> >
> > > use dma_mapping_error() instead of comparing the returned address with
> > > zero after dma_map_single().
> >
> > Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> >
> > However, the parentheses in &(rtsx->pci->dev) are really unpleasant.
> > Especially since they make the call to dma_map_single different from the
> > call to dma_mapping_error.
> >
> > Maybe you could send a patch series to also get rid of them?
> >
> > julia
> >
> Sure. should I send it as v2? Also, I noticed in the discussion in the
> previous thread about keeping the acked, yet I'm not sure how to do it.
> could yo advise me on that please?

Yes, a v2 would be good.

For the ack, just put it under your signed off by, for the specific patch
that I acked.

julia

>
> Thank you,
> Haneen
> > >
> > > Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
> > > ---
> > >  drivers/staging/rts5208/rtsx_transport.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/staging/rts5208/rtsx_transport.c b/drivers/staging/rts5208/rtsx_transport.c
> > > index f27491e..0c9549b 100644
> > > --- a/drivers/staging/rts5208/rtsx_transport.c
> > > +++ b/drivers/staging/rts5208/rtsx_transport.c
> > > @@ -653,7 +653,7 @@ static int rtsx_transfer_buf(struct rtsx_chip *chip, u8 card, void *buf,
> > >  		return -ENXIO;
> > >
> > >  	addr = dma_map_single(&(rtsx->pci->dev), buf, len, dma_dir);
> > > -	if (!addr)
> > > +	if (dma_mapping_error(&rtsx->pci->dev, addr))
> > >  		return -ENOMEM;
> > >
> > >  	if (card == SD_CARD)
> > > --
> > > 1.9.1
> > >
> > > --
> > > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160209103540.GA27735%40haneenVB.
> > > For more options, visit https://groups.google.com/d/optout.
> > >
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160209112101.GA27970%40haneenVB.
> For more options, visit https://groups.google.com/d/optout.
>