From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/6] arm64: compat: Check for AArch32 state
Date: Tue, 9 Feb 2016 17:36:06 +0000 [thread overview]
Message-ID: <20160209173606.GX22874@arm.com> (raw)
In-Reply-To: <1453980737-6126-7-git-send-email-suzuki.poulose@arm.com>
On Thu, Jan 28, 2016 at 11:32:17AM +0000, Suzuki K Poulose wrote:
> Make sure we have AArch32 state available for running COMPAT binaries.
>
> Signed-off-by: Yury Norov <ynorov@caviumnetworks.com>
> [ Added checks for ELF HWCAP, Use cap bit in cap_hwcaps ]
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
[...]
> diff --git a/arch/arm64/kernel/cpuinfo.c b/arch/arm64/kernel/cpuinfo.c
> index 8cc2a86..2890b74 100644
> --- a/arch/arm64/kernel/cpuinfo.c
> +++ b/arch/arm64/kernel/cpuinfo.c
> @@ -124,7 +124,8 @@ static int c_show(struct seq_file *m, void *v)
> * software which does already (at least for 32-bit).
> */
> seq_puts(m, "Features\t:");
> - if (personality(current->personality) == PER_LINUX32) {
> + if (system_supports_32bit_el0() &&
> + personality(current->personality) == PER_LINUX32) {
Wouldn't it be better to prevent tasks changing to the PER_LINUX32
personality on systems that don't support AArch32 at EL0?
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com,
mark.rutland@arm.com, ynorov@caviumnetworks.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] arm64: compat: Check for AArch32 state
Date: Tue, 9 Feb 2016 17:36:06 +0000 [thread overview]
Message-ID: <20160209173606.GX22874@arm.com> (raw)
In-Reply-To: <1453980737-6126-7-git-send-email-suzuki.poulose@arm.com>
On Thu, Jan 28, 2016 at 11:32:17AM +0000, Suzuki K Poulose wrote:
> Make sure we have AArch32 state available for running COMPAT binaries.
>
> Signed-off-by: Yury Norov <ynorov@caviumnetworks.com>
> [ Added checks for ELF HWCAP, Use cap bit in cap_hwcaps ]
> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
[...]
> diff --git a/arch/arm64/kernel/cpuinfo.c b/arch/arm64/kernel/cpuinfo.c
> index 8cc2a86..2890b74 100644
> --- a/arch/arm64/kernel/cpuinfo.c
> +++ b/arch/arm64/kernel/cpuinfo.c
> @@ -124,7 +124,8 @@ static int c_show(struct seq_file *m, void *v)
> * software which does already (at least for 32-bit).
> */
> seq_puts(m, "Features\t:");
> - if (personality(current->personality) == PER_LINUX32) {
> + if (system_supports_32bit_el0() &&
> + personality(current->personality) == PER_LINUX32) {
Wouldn't it be better to prevent tasks changing to the PER_LINUX32
personality on systems that don't support AArch32 at EL0?
Will
next prev parent reply other threads:[~2016-02-09 17:36 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 11:32 [PATCH 0/6] Support for systems without AArch32 state Suzuki K Poulose
2016-01-28 11:32 ` Suzuki K Poulose
2016-01-28 11:32 ` [PATCH 1/6] arm64: hwcaps: Cleanup naming Suzuki K Poulose
2016-01-28 11:32 ` Suzuki K Poulose
2016-01-28 11:32 ` [PATCH 2/6] arm64: HWCAP: Split COMPAT HWCAP table entries Suzuki K Poulose
2016-01-28 11:32 ` Suzuki K Poulose
2016-01-28 11:32 ` [PATCH 3/6] arm64: Add helpers for detecting AArch32 support at EL0 Suzuki K Poulose
2016-01-28 11:32 ` Suzuki K Poulose
2016-01-28 11:32 ` [PATCH 4/6] arm64: cpufeature: Check availability of AArch32 Suzuki K Poulose
2016-01-28 11:32 ` Suzuki K Poulose
2016-01-28 11:32 ` [PATCH 5/6] arm64: cpufeature: Track 32bit EL0 support Suzuki K Poulose
2016-01-28 11:32 ` Suzuki K Poulose
2016-01-28 11:32 ` [PATCH 6/6] arm64: compat: Check for AArch32 state Suzuki K Poulose
2016-01-28 11:32 ` Suzuki K Poulose
2016-02-09 17:36 ` Will Deacon [this message]
2016-02-09 17:36 ` Will Deacon
2016-02-22 11:37 ` Suzuki K. Poulose
2016-02-22 11:37 ` Suzuki K. Poulose
2016-02-22 14:03 ` [PATCH 0/6] Support for systems without " Suzuki K. Poulose
2016-02-22 14:03 ` Suzuki K. Poulose
2016-02-22 14:38 ` Yury Norov
2016-02-22 14:38 ` Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160209173606.GX22874@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.