From: Greg KH <gregkh@linuxfoundation.org>
To: Janani Ravichandran <janani.rvchndrn@gmail.com>
Cc: outreachy-kernel <outreachy-kernel@googlegroups.com>
Subject: Re: [Outreachy kernel] Re: [PATCH] staging: slicoss: Align #define constants
Date: Tue, 9 Feb 2016 22:11:05 -0800 [thread overview]
Message-ID: <20160210061105.GA22525@kroah.com> (raw)
In-Reply-To: <cd332ec7-4bf6-4854-859d-3ab667383154@googlegroups.com>
On Tue, Feb 09, 2016 at 08:10:51PM -0800, Janani Ravichandran wrote:
> This is embarrassing. The alignment looked fine on vim. All the constants were
> in the
> same column. I don't understand why the alignment looks so bad in the patch.
> Can someone
> explain this? :/
What looks wrong to you now? The patch looks good to me, please
explain, by quoting the lines you feel are not correct.
thanks,
greg k-h
next prev parent reply other threads:[~2016-02-10 6:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 9:06 [PATCH] staging: slicoss: Align #define constants Janani Ravichandran
2016-02-10 4:10 ` Janani Ravichandran
2016-02-10 6:11 ` Greg KH [this message]
2016-02-10 7:24 ` [Outreachy kernel] " Julia Lawall
2016-02-10 7:16 ` Julia Lawall
2016-02-10 7:18 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160210061105.GA22525@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=janani.rvchndrn@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.