* [PATCH] staging: slicoss: Align #define constants
@ 2016-02-10 9:06 Janani Ravichandran
2016-02-10 4:10 ` Janani Ravichandran
0 siblings, 1 reply; 6+ messages in thread
From: Janani Ravichandran @ 2016-02-10 9:06 UTC (permalink / raw)
To: outreachy-kernel
Aligning the constants in the macros improves code readability.
Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com>
---
drivers/staging/slicoss/slicoss.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
index c490b71..a91c60a 100644
--- a/drivers/staging/slicoss/slicoss.c
+++ b/drivers/staging/slicoss/slicoss.c
@@ -58,9 +58,9 @@
#define DEBUG_MICROCODE 1
#define DBG 1
#define SLIC_INTERRUPT_PROCESS_LIMIT 1
-#define SLIC_OFFLOAD_IP_CHECKSUM 1
-#define STATS_TIMER_INTERVAL 2
-#define PING_TIMER_INTERVAL 1
+#define SLIC_OFFLOAD_IP_CHECKSUM 1
+#define STATS_TIMER_INTERVAL 2
+#define PING_TIMER_INTERVAL 1
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
#include <linux/kernel.h>
--
2.5.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: slicoss: Align #define constants
2016-02-10 9:06 [PATCH] staging: slicoss: Align #define constants Janani Ravichandran
@ 2016-02-10 4:10 ` Janani Ravichandran
2016-02-10 6:11 ` [Outreachy kernel] " Greg KH
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Janani Ravichandran @ 2016-02-10 4:10 UTC (permalink / raw)
To: outreachy-kernel
[-- Attachment #1.1: Type: text/plain, Size: 201 bytes --]
This is embarrassing. The alignment looked fine on vim. All the constants
were in the
same column. I don't understand why the alignment looks so bad in the
patch. Can someone
explain this? :/
>
>
[-- Attachment #1.2: Type: text/html, Size: 363 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Outreachy kernel] Re: [PATCH] staging: slicoss: Align #define constants
2016-02-10 4:10 ` Janani Ravichandran
@ 2016-02-10 6:11 ` Greg KH
2016-02-10 7:24 ` Julia Lawall
2016-02-10 7:16 ` Julia Lawall
2016-02-10 7:18 ` Julia Lawall
2 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2016-02-10 6:11 UTC (permalink / raw)
To: Janani Ravichandran; +Cc: outreachy-kernel
On Tue, Feb 09, 2016 at 08:10:51PM -0800, Janani Ravichandran wrote:
> This is embarrassing. The alignment looked fine on vim. All the constants were
> in the
> same column. I don't understand why the alignment looks so bad in the patch.
> Can someone
> explain this? :/
What looks wrong to you now? The patch looks good to me, please
explain, by quoting the lines you feel are not correct.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH] staging: slicoss: Align #define constants
2016-02-10 6:11 ` [Outreachy kernel] " Greg KH
@ 2016-02-10 7:24 ` Julia Lawall
0 siblings, 0 replies; 6+ messages in thread
From: Julia Lawall @ 2016-02-10 7:24 UTC (permalink / raw)
To: Greg KH; +Cc: Janani Ravichandran, outreachy-kernel
On Tue, 9 Feb 2016, Greg KH wrote:
> On Tue, Feb 09, 2016 at 08:10:51PM -0800, Janani Ravichandran wrote:
> > This is embarrassing. The alignment looked fine on vim. All the constants were
> > in the
> > same column. I don't understand why the alignment looks so bad in the patch.
> > Can someone
> > explain this? :/
>
> What looks wrong to you now? The patch looks good to me, please
> explain, by quoting the lines you feel are not correct.
The three context lines above the patch don't seem to be lined up with
each other.
julia
>
> thanks,
>
> greg k-h
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160210061105.GA22525%40kroah.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH] staging: slicoss: Align #define constants
2016-02-10 4:10 ` Janani Ravichandran
2016-02-10 6:11 ` [Outreachy kernel] " Greg KH
@ 2016-02-10 7:16 ` Julia Lawall
2016-02-10 7:18 ` Julia Lawall
2 siblings, 0 replies; 6+ messages in thread
From: Julia Lawall @ 2016-02-10 7:16 UTC (permalink / raw)
To: Janani Ravichandran; +Cc: outreachy-kernel
On Tue, 9 Feb 2016, Janani Ravichandran wrote:
> This is embarrassing. The alignment looked fine on vim. All the constants
> were in the
> same column. I don't understand why the alignment looks so bad in the patch.
> Can someone
> explain this? :/
I had the impression that a newline disappeared.
julia
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/cd332ec7-4bf6-4854-859d-
> 3ab667383154%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] Re: [PATCH] staging: slicoss: Align #define constants
2016-02-10 4:10 ` Janani Ravichandran
2016-02-10 6:11 ` [Outreachy kernel] " Greg KH
2016-02-10 7:16 ` Julia Lawall
@ 2016-02-10 7:18 ` Julia Lawall
2 siblings, 0 replies; 6+ messages in thread
From: Julia Lawall @ 2016-02-10 7:18 UTC (permalink / raw)
To: Janani Ravichandran; +Cc: outreachy-kernel
On Tue, 9 Feb 2016, Janani Ravichandran wrote:
> This is embarrassing. The alignment looked fine on vim. All the constants
> were in the
> same column. I don't understand why the alignment looks so bad in the patch.
> Can someone
> explain this? :/
Oops, sorry I was thinking of the case of the 4 with lots of space in
front of it.
Perhaps it is a tab issue? Check whether the various numbers are
preceded by spaces or tabs.
julia
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/cd332ec7-4bf6-4854-859d-
> 3ab667383154%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-02-10 7:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-10 9:06 [PATCH] staging: slicoss: Align #define constants Janani Ravichandran
2016-02-10 4:10 ` Janani Ravichandran
2016-02-10 6:11 ` [Outreachy kernel] " Greg KH
2016-02-10 7:24 ` Julia Lawall
2016-02-10 7:16 ` Julia Lawall
2016-02-10 7:18 ` Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.