From: Ralf Baechle <ralf@linux-mips.org>
To: John Crispin <blogic@openwrt.org>
Cc: weiyj_lk@163.com, Matthias Brugger <matthias.bgg@gmail.com>,
linux-mips@linux-mips.org,
Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] MIPS: pci-mt7620: Fix return value check in mt7620_pci_probe()
Date: Wed, 10 Feb 2016 10:01:06 +0100 [thread overview]
Message-ID: <20160210090106.GA10352@linux-mips.org> (raw)
In-Reply-To: <56B613D3.2070709@openwrt.org>
On Sat, Feb 06, 2016 at 04:40:03PM +0100, John Crispin wrote:
> On 06/02/2016 15:24, weiyj_lk@163.com wrote:
> > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> >
> > In case of error, the function devm_ioremap_resource() returns
> > ERR_PTR() and never returns NULL. The NULL test in the return
> > value check should be replaced with IS_ERR().
> >
> > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Hi,
>
> thanks for the fix.
>
> Acked-by: John Crispin <blogic@openwrt.org>
>
> @Ralf: can you merge this via LMO with the next PR please ?
>
> @mbgg: ignore the patch please it is for the legacy MIPS SoCs
Applied. Thanks folks,
Ralf
WARNING: multiple messages have this Message-ID (diff)
From: ralf@linux-mips.org (Ralf Baechle)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] MIPS: pci-mt7620: Fix return value check in mt7620_pci_probe()
Date: Wed, 10 Feb 2016 10:01:06 +0100 [thread overview]
Message-ID: <20160210090106.GA10352@linux-mips.org> (raw)
In-Reply-To: <56B613D3.2070709@openwrt.org>
On Sat, Feb 06, 2016 at 04:40:03PM +0100, John Crispin wrote:
> On 06/02/2016 15:24, weiyj_lk at 163.com wrote:
> > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> >
> > In case of error, the function devm_ioremap_resource() returns
> > ERR_PTR() and never returns NULL. The NULL test in the return
> > value check should be replaced with IS_ERR().
> >
> > Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Hi,
>
> thanks for the fix.
>
> Acked-by: John Crispin <blogic@openwrt.org>
>
> @Ralf: can you merge this via LMO with the next PR please ?
>
> @mbgg: ignore the patch please it is for the legacy MIPS SoCs
Applied. Thanks folks,
Ralf
next prev parent reply other threads:[~2016-02-10 9:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-06 14:24 [PATCH] MIPS: pci-mt7620: Fix return value check in mt7620_pci_probe() weiyj_lk
2016-02-06 14:24 ` weiyj_lk at 163.com
2016-02-06 15:40 ` John Crispin
2016-02-06 15:40 ` John Crispin
2016-02-10 9:01 ` Ralf Baechle [this message]
2016-02-10 9:01 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160210090106.GA10352@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=blogic@openwrt.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mips@linux-mips.org \
--cc=matthias.bgg@gmail.com \
--cc=weiyj_lk@163.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.