From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Greg Kurz <gkurz@linux.vnet.ibm.com>
Cc: netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH 2/2] vhost: disentangle vring endianness stuff from the core code
Date: Wed, 10 Feb 2016 14:23:33 +0100 [thread overview]
Message-ID: <20160210142333.744e4446.cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <20160210140843.64ea5aa1@bahia.huguette.org>
On Wed, 10 Feb 2016 14:08:43 +0100
Greg Kurz <gkurz@linux.vnet.ibm.com> wrote:
> But you are right, there is a bug: we should rollback if vhost_init_used()
> fails. Something like below:
>
> err_used:
> vq->private_data = oldsock;
> vhost_net_enable_vq(n, vq);
> + vhost_adjust_vring_endian(vq);
Shouldn't we switch back before we reenable? Or have I lost myself in
this maze here again?
> if (ubufs)
> vhost_net_ubuf_put_wait_and_free(ubufs);
> err_ubufs:
WARNING: multiple messages have this Message-ID (diff)
From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Greg Kurz <gkurz@linux.vnet.ibm.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, virtualization@lists.linux-foundation.org
Subject: Re: [PATCH 2/2] vhost: disentangle vring endianness stuff from the core code
Date: Wed, 10 Feb 2016 14:23:33 +0100 [thread overview]
Message-ID: <20160210142333.744e4446.cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <20160210140843.64ea5aa1@bahia.huguette.org>
On Wed, 10 Feb 2016 14:08:43 +0100
Greg Kurz <gkurz@linux.vnet.ibm.com> wrote:
> But you are right, there is a bug: we should rollback if vhost_init_used()
> fails. Something like below:
>
> err_used:
> vq->private_data = oldsock;
> vhost_net_enable_vq(n, vq);
> + vhost_adjust_vring_endian(vq);
Shouldn't we switch back before we reenable? Or have I lost myself in
this maze here again?
> if (ubufs)
> vhost_net_ubuf_put_wait_and_free(ubufs);
> err_ubufs:
next prev parent reply other threads:[~2016-02-10 13:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 17:09 [PATCH 0/2] vhost: cross-endian code cleanup Greg Kurz
2016-01-13 17:09 ` [PATCH 1/2] vhost: helpers to enable/disable vring endianness Greg Kurz
2016-01-21 9:55 ` Cornelia Huck
2016-01-21 9:55 ` Cornelia Huck
2016-02-10 11:21 ` Michael S. Tsirkin
2016-02-10 12:11 ` Greg Kurz
2016-02-10 13:12 ` Cornelia Huck
2016-02-10 13:12 ` Cornelia Huck
2016-02-10 15:08 ` Michael S. Tsirkin
2016-02-10 15:27 ` Greg Kurz
2016-02-10 15:27 ` Greg Kurz
2016-01-13 17:09 ` [PATCH 2/2] vhost: disentangle vring endianness stuff from the core code Greg Kurz
2016-01-21 9:56 ` Cornelia Huck
2016-01-21 9:56 ` Cornelia Huck
2016-02-10 11:48 ` Michael S. Tsirkin
2016-02-10 11:48 ` Michael S. Tsirkin
2016-02-10 13:08 ` Greg Kurz
2016-02-10 13:23 ` Cornelia Huck [this message]
2016-02-10 13:23 ` Cornelia Huck
2016-02-10 13:40 ` Greg Kurz
2016-02-10 13:40 ` Greg Kurz
2016-01-27 10:25 ` [PATCH 0/2] vhost: cross-endian code cleanup Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160210142333.744e4446.cornelia.huck@de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=gkurz@linux.vnet.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.