All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: xfs@oss.sgi.com
Subject: Re: block allocations for the refcount btree
Date: Wed, 10 Feb 2016 11:07:38 -0800	[thread overview]
Message-ID: <20160210190738.GA13051@infradead.org> (raw)
In-Reply-To: <20160210095010.GC23904@birch.djwong.org>

On Wed, Feb 10, 2016 at 01:50:10AM -0800, Darrick J. Wong wrote:
> That's odd... I'd have thought that the AG reservation would always be able
> to handle a refcount btree expansion, since it calculates how many blocks
> are needed to handle the worst case of 1 record per extent.  There's also
> a bug where we undercount the number of blocks already used, so it should
> have an extra big reservation.
> 
> OTOH I've seen occasional ENOSPCs in generic/186 and generic/168 too, so I
> guess something's going wrong.  Maybe the xfs_ag_resv* tracepoints can help?

I'm not seeing an ENOSPC, I run into:

[  640.924891] XFS: Assertion failed: tp->t_blk_res_used <= tp->t_blk_res, file: fs/xfs/xfs_trans.c, line: 315

Which asserts that the current transaction is using up more blocks from
its reservation than it reserved.  The AG reservation seems to operate
on a different level than that.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2016-02-10 19:07 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-10  9:30 block allocations for the refcount btree Christoph Hellwig
2016-02-10  9:50 ` Darrick J. Wong
2016-02-10 19:07   ` Christoph Hellwig [this message]
2016-02-10 21:40     ` Dave Chinner
2016-02-11 14:09       ` Brian Foster
2016-02-11 20:21         ` Dave Chinner
2016-02-12 19:10       ` Christoph Hellwig
2016-02-13  2:33         ` Dave Chinner
2016-02-13  4:44           ` Darrick J. Wong
2016-02-13  8:02             ` Christoph Hellwig
2016-02-13  7:48           ` Christoph Hellwig
2016-02-14  0:21             ` Dave Chinner
2016-03-01 18:18         ` Darrick J. Wong
2016-03-01 20:40           ` Christoph Hellwig
2016-03-02  5:24             ` Darrick J. Wong
2016-03-02  9:59               ` Christoph Hellwig
2016-03-02 16:41                 ` Darrick J. Wong
2016-03-02 16:57                   ` Christoph Hellwig
2016-03-02 21:21                     ` Darrick J. Wong
2016-03-03 14:05                       ` Christoph Hellwig
2016-03-04  1:36                         ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160210190738.GA13051@infradead.org \
    --to=hch@infradead.org \
    --cc=darrick.wong@oracle.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.