From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com, "Darrick J. Wong" <darrick.wong@oracle.com>
Subject: Re: block allocations for the refcount btree
Date: Sun, 14 Feb 2016 11:21:35 +1100 [thread overview]
Message-ID: <20160214002135.GG14668@dastard> (raw)
In-Reply-To: <20160213074827.GA11543@infradead.org>
On Fri, Feb 12, 2016 at 11:48:27PM -0800, Christoph Hellwig wrote:
> On Sat, Feb 13, 2016 at 01:33:10PM +1100, Dave Chinner wrote:
> > > allocate an extent (or rather just a single block) in xfs_alloc_ag_vextent
> > > as called from xfs_refcountbt_alloc_block. The reservation helps us to
> > > ensure this block is always available, but we still need to account for
> > > that in xfs_trans_reserve(), which we currently don't do for itruncate
> > > transactions.
> >
> > Ok, so we may have two different issues with a similar failure
> > symptom. As it is, I don't think this is a show stopper - we're
> > expecting to find these sorts of issues as we go along (hence the
> > experimental tag on the feature) and I think, at this point, getting
> > review and an initial merge done is more important...
>
> This triggers 100% reproducible over NFS, and as outlined I'm
> also pretty sure about the root cause. I don't think this is something
> to be ignored.
I didn't say we should to ignore it - I simply stated my priority
was getting the code reviewed and merged. That doesn't stop you or
Darrick from working on a fix - if that happens after the initial
merge, we've still got the whole -rc cycle to find and fix issues
like this.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-02-14 0:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 9:30 block allocations for the refcount btree Christoph Hellwig
2016-02-10 9:50 ` Darrick J. Wong
2016-02-10 19:07 ` Christoph Hellwig
2016-02-10 21:40 ` Dave Chinner
2016-02-11 14:09 ` Brian Foster
2016-02-11 20:21 ` Dave Chinner
2016-02-12 19:10 ` Christoph Hellwig
2016-02-13 2:33 ` Dave Chinner
2016-02-13 4:44 ` Darrick J. Wong
2016-02-13 8:02 ` Christoph Hellwig
2016-02-13 7:48 ` Christoph Hellwig
2016-02-14 0:21 ` Dave Chinner [this message]
2016-03-01 18:18 ` Darrick J. Wong
2016-03-01 20:40 ` Christoph Hellwig
2016-03-02 5:24 ` Darrick J. Wong
2016-03-02 9:59 ` Christoph Hellwig
2016-03-02 16:41 ` Darrick J. Wong
2016-03-02 16:57 ` Christoph Hellwig
2016-03-02 21:21 ` Darrick J. Wong
2016-03-03 14:05 ` Christoph Hellwig
2016-03-04 1:36 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160214002135.GG14668@dastard \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.