All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] staging: wilc1000: remove parentheses on right hand side of assignment
@ 2016-02-11  5:34 Alison Schofield
  2016-02-11  6:04 ` [Outreachy kernel] " Julia Lawall
  0 siblings, 1 reply; 2+ messages in thread
From: Alison Schofield @ 2016-02-11  5:34 UTC (permalink / raw)
  To: outreachy-kernel

Remove the unnecessary parens on right hand side of assignment.

Found using Coccinelle:
@@
identifier x;
expression e1, e2;
@@
- x = (e1 << e2)
+ x = e1 << e2

Signed-off-by: Alison Schofield <amsfield22@gmail.com>
---
 drivers/staging/wilc1000/wilc_wlan.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/wilc_wlan.c
index 98b21d4..c1da8f0 100644
--- a/drivers/staging/wilc1000/wilc_wlan.c
+++ b/drivers/staging/wilc1000/wilc_wlan.c
@@ -921,11 +921,11 @@ static void wilc_wlan_handle_isr_ext(struct wilc *wilc, u32 int_status)
 	int ret = 0;
 	struct rxq_entry_t *rqe;
 
-	size = ((int_status & 0x7fff) << 2);
+	size = (int_status & 0x7fff) << 2;
 
 	while (!size && retries < 10) {
 		wilc->hif_func->hif_read_size(wilc, &size);
-		size = ((size & 0x7fff) << 2);
+		size = (size & 0x7fff) << 2;
 		retries++;
 	}
 
-- 
2.1.4



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Outreachy kernel] [PATCH] staging: wilc1000: remove parentheses on right hand side of assignment
  2016-02-11  5:34 [PATCH] staging: wilc1000: remove parentheses on right hand side of assignment Alison Schofield
@ 2016-02-11  6:04 ` Julia Lawall
  0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2016-02-11  6:04 UTC (permalink / raw)
  To: Alison Schofield; +Cc: outreachy-kernel

On Wed, 10 Feb 2016, Alison Schofield wrote:

> Remove the unnecessary parens on right hand side of assignment.
> 
> Found using Coccinelle:
> @@
> identifier x;
> expression e1, e2;
> @@
> - x = (e1 << e2)
> + x = e1 << e2
> 
> Signed-off-by: Alison Schofield <amsfield22@gmail.com>

Acked-by: Julia Lawall <julia.lawall@lip6.fr>

> ---
>  drivers/staging/wilc1000/wilc_wlan.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/wilc_wlan.c
> index 98b21d4..c1da8f0 100644
> --- a/drivers/staging/wilc1000/wilc_wlan.c
> +++ b/drivers/staging/wilc1000/wilc_wlan.c
> @@ -921,11 +921,11 @@ static void wilc_wlan_handle_isr_ext(struct wilc *wilc, u32 int_status)
>  	int ret = 0;
>  	struct rxq_entry_t *rqe;
>  
> -	size = ((int_status & 0x7fff) << 2);
> +	size = (int_status & 0x7fff) << 2;
>  
>  	while (!size && retries < 10) {
>  		wilc->hif_func->hif_read_size(wilc, &size);
> -		size = ((size & 0x7fff) << 2);
> +		size = (size & 0x7fff) << 2;
>  		retries++;
>  	}
>  
> -- 
> 2.1.4
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160211053430.GA8222%40d830.WORKGROUP.
> For more options, visit https://groups.google.com/d/optout.
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-02-11  6:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-11  5:34 [PATCH] staging: wilc1000: remove parentheses on right hand side of assignment Alison Schofield
2016-02-11  6:04 ` [Outreachy kernel] " Julia Lawall

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.