* [PATCH] Staging: vt6655: Add check dma_mapping_error
@ 2016-02-11 18:34 Haneen Mohammed
2016-02-12 4:00 ` [Outreachy kernel] " Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Haneen Mohammed @ 2016-02-11 18:34 UTC (permalink / raw)
To: outreachy-kernel
This patch checks for dma_mapping_error() after using dma_map_single.
If the dma map fails we release skb buff allocated by dev_alloc_skb() to
avoid possible causes of resource leak.
Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
---
drivers/staging/vt6655/device_main.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
index ad0fb84..8a1ed62 100644
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_main.c
@@ -742,6 +742,11 @@ static bool device_alloc_rx_buf(struct vnt_private *priv,
dma_map_single(&priv->pcid->dev,
skb_put(rd_info->skb, skb_tailroom(rd_info->skb)),
priv->rx_buf_sz, DMA_FROM_DEVICE);
+ if (dma_mapping_error(&priv->pcid->dev, rd_info->skb_dma)) {
+ dev_kfree_skb(rd_info->skb);
+ rd_info->skb = NULL;
+ return false;
+ }
*((unsigned int *)&rd->rd0) = 0; /* FIX cast */
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: vt6655: Add check dma_mapping_error
2016-02-11 18:34 [PATCH] Staging: vt6655: Add check dma_mapping_error Haneen Mohammed
@ 2016-02-12 4:00 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2016-02-12 4:00 UTC (permalink / raw)
To: Haneen Mohammed; +Cc: outreachy-kernel
On Thu, Feb 11, 2016 at 09:34:40PM +0300, Haneen Mohammed wrote:
> This patch checks for dma_mapping_error() after using dma_map_single.
> If the dma map fails we release skb buff allocated by dev_alloc_skb() to
> avoid possible causes of resource leak.
>
> Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
Nice catch.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-12 4:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-11 18:34 [PATCH] Staging: vt6655: Add check dma_mapping_error Haneen Mohammed
2016-02-12 4:00 ` [Outreachy kernel] " Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.