Re: [Qemu-devel] [PATCH v2 0/4] hw/ppc/spapr: Add "Processor Register Hypervisor Resource Access" H-calls

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1256 bytes --]

On Thu, Feb 11, 2016 at 01:47:17PM +0100, Thomas Huth wrote:
> While we were recently debugging a problem with the H_SET_DABR
> call [1], I noticed that some hypercalls from the chapter 14.5.4.3
> ("Processor Register Hypervisor Resource Access") from the LoPAPR
> spec [2] are still missing in QEMU.
> So here's are some patches that implement these hypercalls. Linux
> apparently does not depend on these hypercalls yet (otherwise somebody
> would have noticed this earlier), but the hypercalls are rather simple,
> so I think the implementations are quite straight-forward and easy to
> read.
> 
> v2:
> - Don't use set_spr() and set cpu->env.spr[] directly instead
> - Completely reworked the H_PAGE_INIT patch to map the source
>   and target pages for higher speed, and to be able to flush now
>   the caches if requested.

I've merged 1-3 into ppc-for-2.6.  My only concern with those is
whether we need to be setting some extra flags in the ibm,hypertas
property now that they are implemented.

I still have some comments on 4/4.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]