From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sudeep Dutt <sudeep.dutt@intel.com>
Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch 2/2] misc: mic: silence an overflow warning
Date: Fri, 12 Feb 2016 06:44:34 +0000 [thread overview]
Message-ID: <20160212064434.GE22756@mwanda> (raw)
Static checkers complain that the this is a potential array overflow.
We verify that it's not on the next line so this code is OK, but
static checker warnings are annoying.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
We would have caught CVE-2015-5327 if we had ordered it to check first
before using the offset.
diff --git a/drivers/misc/mic/vop/vop_vringh.c b/drivers/misc/mic/vop/vop_vringh.c
index c3613f3..e94c7fb 100644
--- a/drivers/misc/mic/vop/vop_vringh.c
+++ b/drivers/misc/mic/vop/vop_vringh.c
@@ -848,12 +848,13 @@ static int vop_virtio_copy_desc(struct vop_vdev *vdev,
struct mic_copy_desc *copy)
{
int err;
- struct vop_vringh *vvr = &vdev->vvr[copy->vr_idx];
+ struct vop_vringh *vvr;
err = vop_verify_copy_args(vdev, copy);
if (err)
return err;
+ vvr = &vdev->vvr[copy->vr_idx];
mutex_lock(&vvr->vr_mutex);
if (!vop_vdevup(vdev)) {
err = -ENODEV;
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sudeep Dutt <sudeep.dutt@intel.com>
Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch 2/2] misc: mic: silence an overflow warning
Date: Fri, 12 Feb 2016 09:44:34 +0300 [thread overview]
Message-ID: <20160212064434.GE22756@mwanda> (raw)
Static checkers complain that the this is a potential array overflow.
We verify that it's not on the next line so this code is OK, but
static checker warnings are annoying.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
We would have caught CVE-2015-5327 if we had ordered it to check first
before using the offset.
diff --git a/drivers/misc/mic/vop/vop_vringh.c b/drivers/misc/mic/vop/vop_vringh.c
index c3613f3..e94c7fb 100644
--- a/drivers/misc/mic/vop/vop_vringh.c
+++ b/drivers/misc/mic/vop/vop_vringh.c
@@ -848,12 +848,13 @@ static int vop_virtio_copy_desc(struct vop_vdev *vdev,
struct mic_copy_desc *copy)
{
int err;
- struct vop_vringh *vvr = &vdev->vvr[copy->vr_idx];
+ struct vop_vringh *vvr;
err = vop_verify_copy_args(vdev, copy);
if (err)
return err;
+ vvr = &vdev->vvr[copy->vr_idx];
mutex_lock(&vvr->vr_mutex);
if (!vop_vdevup(vdev)) {
err = -ENODEV;
next reply other threads:[~2016-02-12 6:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 6:44 Dan Carpenter [this message]
2016-02-12 6:44 ` [patch 2/2] misc: mic: silence an overflow warning Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160212064434.GE22756@mwanda \
--to=dan.carpenter@oracle.com \
--cc=ashutosh.dixit@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudeep.dutt@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.