From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Sergey Fedorov <serge.fdrv@gmail.com>,
qemu-arm <qemu-arm@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Patch Tracking <patches@linaro.org>
Subject: Re: [Qemu-devel] [PATCH 3/4] target-arm: Combine user-only and softmmu get/set_r13_banked()
Date: Fri, 12 Feb 2016 16:16:08 +0100 [thread overview]
Message-ID: <20160212151608.GI31433@toto> (raw)
In-Reply-To: <CAFEAcA_00+sVTot-q5iHKLDiLbPRFsRTBQNE4Dbswt1haaxwGQ@mail.gmail.com>
On Fri, Feb 12, 2016 at 03:15:22PM +0000, Peter Maydell wrote:
> On 12 February 2016 at 15:12, Edgar E. Iglesias
> <edgar.iglesias@gmail.com> wrote:
> > On Thu, Feb 11, 2016 at 07:11:48PM +0000, Peter Maydell wrote:
> >> The user-mode versions of get/set_r13_banked() exist just to assert
> >> if they're ever called -- the translate time code should never
> >> emit calls to them because SRS from user mode always UNDEF.
> >> There's no code in the softmmu versions that can't compile in
> >> CONFIG_USER_ONLY, so combine the two functions rather than
> >> having completely split versions under ifdefs.
> >>
> >> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> >
> > Hi Peter,
> >
> > Do we really need the assert?
> > If we keep it, can't we have it for both -user and -softmmu (avoiding the ifdef)?
>
> I would be happy to entirely drop the assert, yes.
OK, thanks.
With that change:
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
next prev parent reply other threads:[~2016-02-12 15:19 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 19:11 [Qemu-arm] [PATCH 0/4] target-arm: Clean up trap/undef handling of SRS Peter Maydell
2016-02-11 19:11 ` [Qemu-devel] " Peter Maydell
2016-02-11 19:11 ` [Qemu-arm] [PATCH 1/4] " Peter Maydell
2016-02-11 19:11 ` [Qemu-devel] " Peter Maydell
2016-02-12 8:48 ` [Qemu-arm] " Sergey Fedorov
2016-02-12 8:48 ` [Qemu-devel] " Sergey Fedorov
2016-02-12 14:56 ` Edgar E. Iglesias
2016-02-11 19:11 ` [Qemu-arm] [PATCH 2/4] target-arm: Move get/set_r13_banked() to op_helper.c Peter Maydell
2016-02-11 19:11 ` [Qemu-devel] " Peter Maydell
2016-02-12 8:56 ` [Qemu-arm] " Sergey Fedorov
2016-02-12 8:56 ` [Qemu-devel] " Sergey Fedorov
2016-02-12 15:05 ` [Qemu-arm] " Edgar E. Iglesias
2016-02-12 15:05 ` [Qemu-devel] " Edgar E. Iglesias
2016-02-11 19:11 ` [Qemu-arm] [PATCH 3/4] target-arm: Combine user-only and softmmu get/set_r13_banked() Peter Maydell
2016-02-11 19:11 ` [Qemu-devel] " Peter Maydell
2016-02-12 8:58 ` [Qemu-arm] " Sergey Fedorov
2016-02-12 8:58 ` [Qemu-devel] " Sergey Fedorov
2016-02-12 15:12 ` [Qemu-arm] " Edgar E. Iglesias
2016-02-12 15:12 ` [Qemu-devel] " Edgar E. Iglesias
2016-02-12 15:15 ` [Qemu-arm] " Peter Maydell
2016-02-12 15:15 ` [Qemu-devel] " Peter Maydell
2016-02-12 15:16 ` Edgar E. Iglesias [this message]
2016-02-12 15:48 ` [Qemu-arm] " Sergey Fedorov
2016-02-12 15:48 ` [Qemu-devel] " Sergey Fedorov
2016-02-12 15:49 ` [Qemu-arm] " Peter Maydell
2016-02-12 15:49 ` [Qemu-devel] " Peter Maydell
2016-02-12 15:15 ` [Qemu-arm] " Edgar E. Iglesias
2016-02-12 15:15 ` [Qemu-devel] " Edgar E. Iglesias
2016-02-11 19:11 ` [Qemu-arm] [PATCH 4/4] target-arm: UNDEF in the UNPREDICTABLE SRS-from-System case Peter Maydell
2016-02-11 19:11 ` [Qemu-devel] " Peter Maydell
2016-02-12 9:34 ` [Qemu-arm] " Sergey Fedorov
2016-02-12 9:34 ` [Qemu-devel] " Sergey Fedorov
2016-02-12 15:17 ` [Qemu-arm] " Edgar E. Iglesias
2016-02-12 15:17 ` [Qemu-devel] " Edgar E. Iglesias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160212151608.GI31433@toto \
--to=edgar.iglesias@gmail.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=serge.fdrv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.