From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Aleksey Makarov <aleksey.makarov@linaro.org>
Cc: linux-acpi@vger.kernel.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Russell King <linux@arm.linux.org.uk>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Leif Lindholm <leif.lindholm@linaro.org>,
Graeme Gregory <graeme.gregory@linaro.org>,
Al Stone <ahs3@redhat.com>,
Christopher Covington <cov@codeaurora.org>,
Len Brown <lenb@kernel.org>
Subject: Re: [PATCH v2 3/9] ACPI: introduce acpi_table_parse2()
Date: Fri, 12 Feb 2016 10:51:30 -0800 [thread overview]
Message-ID: <20160212185130.GA10095@kroah.com> (raw)
In-Reply-To: <1455299022-11641-4-git-send-email-aleksey.makarov@linaro.org>
On Fri, Feb 12, 2016 at 08:43:34PM +0300, Aleksey Makarov wrote:
> The function acpi_table_parse() has some problems:
> 1 It can be called only from __init code
> 2 It does not pass any data to the handler
> 3 It just throws out the value returned from the handler
>
> These issues are addressed in this patch
Why not just fix acpi_table_parse(), like you have, and not add a new
API call with a "2" at the end of it. That seems crazy to try to
maintain that level of apis.
But I'm not the acpi maintainer(s), so it's their call...
good luck,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org (Greg Kroah-Hartman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/9] ACPI: introduce acpi_table_parse2()
Date: Fri, 12 Feb 2016 10:51:30 -0800 [thread overview]
Message-ID: <20160212185130.GA10095@kroah.com> (raw)
In-Reply-To: <1455299022-11641-4-git-send-email-aleksey.makarov@linaro.org>
On Fri, Feb 12, 2016 at 08:43:34PM +0300, Aleksey Makarov wrote:
> The function acpi_table_parse() has some problems:
> 1 It can be called only from __init code
> 2 It does not pass any data to the handler
> 3 It just throws out the value returned from the handler
>
> These issues are addressed in this patch
Why not just fix acpi_table_parse(), like you have, and not add a new
API call with a "2" at the end of it. That seems crazy to try to
maintain that level of apis.
But I'm not the acpi maintainer(s), so it's their call...
good luck,
greg k-h
next prev parent reply other threads:[~2016-02-12 18:51 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 17:43 [PATCH v2 0/9] ACPI: parse the SPCR table Aleksey Makarov
2016-02-12 17:43 ` Aleksey Makarov
2016-02-12 17:43 ` [PATCH v2 1/9] printk: fix name and type of some variables Aleksey Makarov
2016-02-12 17:43 ` Aleksey Makarov
2016-02-12 17:43 ` [PATCH v2 2/9] ACPI: Change __init to __ref for early_acpi_os_unmap_memory() Aleksey Makarov
2016-02-12 17:43 ` Aleksey Makarov
2016-02-12 17:43 ` Aleksey Makarov
2016-02-12 17:43 ` [PATCH v2 3/9] ACPI: introduce acpi_table_parse2() Aleksey Makarov
2016-02-12 17:43 ` Aleksey Makarov
2016-02-12 18:44 ` kbuild test robot
2016-02-12 18:44 ` kbuild test robot
2016-02-12 18:44 ` kbuild test robot
2016-02-12 18:51 ` Greg Kroah-Hartman [this message]
2016-02-12 18:51 ` Greg Kroah-Hartman
2016-02-12 23:08 ` Rafael J. Wysocki
2016-02-12 23:08 ` Rafael J. Wysocki
2016-02-15 12:57 ` Aleksey Makarov
2016-02-15 12:57 ` Aleksey Makarov
2016-02-12 23:07 ` Rafael J. Wysocki
2016-02-12 23:07 ` Rafael J. Wysocki
2016-02-15 12:51 ` Aleksey Makarov
2016-02-15 12:51 ` Aleksey Makarov
2016-02-12 17:43 ` [PATCH v2 4/9] ACPI: parse SPCR and enable matching console Aleksey Makarov
2016-02-12 17:43 ` Aleksey Makarov
2016-02-12 17:43 ` Aleksey Makarov
2016-02-12 18:53 ` Greg Kroah-Hartman
2016-02-12 18:53 ` Greg Kroah-Hartman
2016-02-12 17:43 ` [PATCH v2 5/9] ACPI: enable ACPI_SPCR_TABLE on ARM64 Aleksey Makarov
2016-02-12 17:43 ` Aleksey Makarov
2016-02-12 17:43 ` [PATCH v2 6/9] ACPI: add definition of DBG2 subtypes Aleksey Makarov
2016-02-12 17:43 ` Aleksey Makarov
2016-02-12 22:47 ` Moore, Robert
2016-02-12 22:47 ` [Devel] " Moore, Robert
2016-02-12 22:47 ` Moore, Robert
2016-02-12 17:43 ` [PATCH v2 7/9] serial: pl011: add acpi_match Aleksey Makarov
2016-02-12 17:43 ` Aleksey Makarov
2016-02-12 17:43 ` [PATCH v2 8/9] serial: 8250: " Aleksey Makarov
2016-02-12 17:43 ` Aleksey Makarov
2016-02-12 18:56 ` Greg Kroah-Hartman
2016-02-12 18:56 ` Greg Kroah-Hartman
2016-02-12 17:43 ` [PATCH v2 9/9] serial: pl011: use SPCR to setup 32-bit access Aleksey Makarov
2016-02-12 17:43 ` Aleksey Makarov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160212185130.GA10095@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ahs3@redhat.com \
--cc=aleksey.makarov@linaro.org \
--cc=cov@codeaurora.org \
--cc=graeme.gregory@linaro.org \
--cc=leif.lindholm@linaro.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.