All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Bhumika Goyal <bhumirks@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] Staging: rtl8723au: Remove unused macros
Date: Sat, 13 Feb 2016 13:22:55 -0800	[thread overview]
Message-ID: <20160213212255.GA5341@kroah.com> (raw)
In-Reply-To: <1455394376-2616-1-git-send-email-bhumirks@gmail.com>

On Sun, Feb 14, 2016 at 01:42:56AM +0530, Bhumika Goyal wrote:
> The macros PlatformAcquireSpinLock and PlatformReleaseSpinLock are not
> used anywhere so remove them. Used grep to find occurences.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
>  drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c b/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c
> index d46d1c7..33eabf4 100644
> --- a/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c
> +++ b/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c
> @@ -80,8 +80,6 @@ if ((BTCoexDbgLevel == _bt_dbg_on_)) {\
>  #define PlatformProcessHCICommands(...)
>  #define PlatformTxBTQueuedPackets(...)
>  #define PlatformIndicateBTACLData(...)	(RT_STATUS_SUCCESS)
> -#define PlatformAcquireSpinLock(padapter, type)
> -#define PlatformReleaseSpinLock(padapter, type)

Can you also remove the commented out places where these macros were
being called?

thanks,

greg k-h


  reply	other threads:[~2016-02-13 21:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-13 20:12 [PATCH] Staging: rtl8723au: Remove unused macros Bhumika Goyal
2016-02-13 21:22 ` Greg KH [this message]
2016-02-14  4:54   ` [Outreachy kernel] " Bhumika Goyal
2016-02-14  7:23     ` Julia Lawall
  -- strict thread matches above, loose matches on Subject: below --
2016-02-14  6:04 Bhumika Goyal
2016-02-15  0:46 ` [Outreachy kernel] " Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160213212255.GA5341@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=bhumirks@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.