[PATCH] Staging: rtl8723au: Remove unused macros

[PATCH] Staging: rtl8723au: Remove unused macros

[Bhumika Goyal]

The macros PlatformAcquireSpinLock and PlatformReleaseSpinLock are not
used anywhere so remove them. Used grep to find occurences.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
 drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c b/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c
index d46d1c7..33eabf4 100644
--- a/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c
+++ b/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c
@@ -80,8 +80,6 @@ if ((BTCoexDbgLevel == _bt_dbg_on_)) {\
 #define PlatformProcessHCICommands(...)
 #define PlatformTxBTQueuedPackets(...)
 #define PlatformIndicateBTACLData(...)	(RT_STATUS_SUCCESS)
-#define PlatformAcquireSpinLock(padapter, type)
-#define PlatformReleaseSpinLock(padapter, type)
 
 #define GET_UNDECORATED_AVERAGE_RSSI(padapter)	\
 			(GET_HAL_DATA(padapter)->dmpriv.EntryMinUndecoratedSmoothedPWDB)
-- 
1.9.1

Re: [Outreachy kernel] [PATCH] Staging: rtl8723au: Remove unused macros

[Greg KH]

On Sun, Feb 14, 2016 at 01:42:56AM +0530, Bhumika Goyal wrote:
> The macros PlatformAcquireSpinLock and PlatformReleaseSpinLock are not
> used anywhere so remove them. Used grep to find occurences.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
>  drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c b/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c
> index d46d1c7..33eabf4 100644
> --- a/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c
> +++ b/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c
> @@ -80,8 +80,6 @@ if ((BTCoexDbgLevel == _bt_dbg_on_)) {\
>  #define PlatformProcessHCICommands(...)
>  #define PlatformTxBTQueuedPackets(...)
>  #define PlatformIndicateBTACLData(...)	(RT_STATUS_SUCCESS)
> -#define PlatformAcquireSpinLock(padapter, type)
> -#define PlatformReleaseSpinLock(padapter, type)

Can you also remove the commented out places where these macros were
being called?

thanks,

greg k-h

Re: [Outreachy kernel] [PATCH] Staging: rtl8723au: Remove unused macros

[Bhumika Goyal]

[-- Attachment #1.1: Type: text/plain, Size: 1291 bytes --]



On Sunday, February 14, 2016 at 2:52:56 AM UTC+5:30, gregkh wrote:
>
> On Sun, Feb 14, 2016 at 01:42:56AM +0530, Bhumika Goyal wrote: 
> > The macros PlatformAcquireSpinLock and PlatformReleaseSpinLock are not 
> > used anywhere so remove them. Used grep to find occurences. 
> > 
> > Signed-off-by: Bhumika Goyal <bhum...@gmail.com <javascript:>> 
> > --- 
> >  drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 2 -- 
> >  1 file changed, 2 deletions(-) 
> > 
> > diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c 
> b/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c 
> > index d46d1c7..33eabf4 100644 
> > --- a/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c 
> > +++ b/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c 
> > @@ -80,8 +80,6 @@ if ((BTCoexDbgLevel == _bt_dbg_on_)) {\ 
> >  #define PlatformProcessHCICommands(...) 
> >  #define PlatformTxBTQueuedPackets(...) 
> >  #define PlatformIndicateBTACLData(...)        (RT_STATUS_SUCCESS) 
> > -#define PlatformAcquireSpinLock(padapter, type) 
> > -#define PlatformReleaseSpinLock(padapter, type) 
>
> Can you also remove the commented out places where these macros were 
> being called? 
>   Yeah sure. I am sending a patchset for that as the comments are in 
> rtl8192u.
> thanks, 
>
> greg k-h 
>

[-- Attachment #1.2: Type: text/html, Size: 1807 bytes --]

Re: [Outreachy kernel] [PATCH] Staging: rtl8723au: Remove unused macros

[Julia Lawall]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 2228 bytes --]



On Sat, 13 Feb 2016, Bhumika Goyal wrote:

> 
> 
> On Sunday, February 14, 2016 at 2:52:56 AM UTC+5:30, gregkh wrote:
>       On Sun, Feb 14, 2016 at 01:42:56AM +0530, Bhumika Goyal wrote:
>       > The macros PlatformAcquireSpinLock and
>       PlatformReleaseSpinLock are not
>       > used anywhere so remove them. Used grep to find occurences.
>       >
>       > Signed-off-by: Bhumika Goyal <bhum...@gmail.com>
>       > ---
>       >  drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 2 --
>       >  1 file changed, 2 deletions(-)
>       >
>       > diff --git
>       a/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c
>       b/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c
>       > index d46d1c7..33eabf4 100644
>       > --- a/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c
>       > +++ b/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c
>       > @@ -80,8 +80,6 @@ if ((BTCoexDbgLevel == _bt_dbg_on_)) {\
>       >  #define PlatformProcessHCICommands(...)
>       >  #define PlatformTxBTQueuedPackets(...)
>       >  #define
>       PlatformIndicateBTACLData(...)        (RT_STATUS_SUCCESS)
>       > -#define PlatformAcquireSpinLock(padapter, type)
>       > -#define PlatformReleaseSpinLock(padapter, type)
> 
>       Can you also remove the commented out places where these macros
>       were
>       being called?
>         Yeah sure. I am sending a patchset for that as the comments
>       are in rtl8192u.
>       thanks,

Please set up your mailer so that it makes a difference between the text 
you are responding to and the text that you write,  Your response looks 
like it is coming from Greg.

julia

> 
>       greg k-h
> 
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/fced03a5-0c11-4936-9521
> -7a69e0624eab%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
> 
> 

[PATCH] Staging: rtl8723au: Remove unused macros

[Bhumika Goyal]

The macros PlatformProcessHCICommands and PlatformTxBTQueuedPackets
are not used anywhere in the kernel so remove them.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
 drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c b/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c
index 33eabf4..1688f66 100644
--- a/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c
+++ b/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c
@@ -77,8 +77,6 @@ if ((BTCoexDbgLevel == _bt_dbg_on_)) {\
 
 #define PlatformZeroMemory(ptr, sz)	memset(ptr, 0, sz)
 
-#define PlatformProcessHCICommands(...)
-#define PlatformTxBTQueuedPackets(...)
 #define PlatformIndicateBTACLData(...)	(RT_STATUS_SUCCESS)
 
 #define GET_UNDECORATED_AVERAGE_RSSI(padapter)	\
-- 
1.9.1

Re: [Outreachy kernel] [PATCH] Staging: rtl8723au: Remove unused macros

[Greg KH]

On Sun, Feb 14, 2016 at 11:34:23AM +0530, Bhumika Goyal wrote:
> The macros PlatformProcessHCICommands and PlatformTxBTQueuedPackets
> are not used anywhere in the kernel so remove them.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>

This subject was the same as another patch you sent :(

Please fix it and resend.

thanks,

greg k-h