[PATCH v2] staging: xgifb: Fix comment style

[PATCH v2] staging: xgifb: Fix comment style

[Janani Ravichandran]

Fix comments to use trailing */ on separate lines and * on subsequent
lines. Found by checkpatch.pl 

Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com>
---
Changes since v1:
 * Corrected accidentally modified comment in line 56 in the previous
   patch

 drivers/staging/xgifb/vb_init.c | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/xgifb/vb_init.c b/drivers/staging/xgifb/vb_init.c
index 879a7e6..7034921 100644
--- a/drivers/staging/xgifb/vb_init.c
+++ b/drivers/staging/xgifb/vb_init.c
@@ -57,7 +57,8 @@ XGINew_GetXG20DRAMType(struct xgi_hw_device_info *HwDeviceExtension,
 		data = xgifb_reg_get(pVBInfo->P3d4, 0x48);
 		/* HOTPLUG_SUPPORT */
 		/* for current XG20 & XG21, GPIOH is floating, driver will
-		 * fix DDR temporarily */
+		 * fix DDR temporarily 
+		 */
 		/* DVI read GPIOH */
 		data &= 0x01; /* 1=DDRII, 0=DDR */
 		/* ~HOTPLUG_SUPPORT */
@@ -354,7 +355,8 @@ static void XGINew_DDR2_DefaultRegister(
 	unsigned long P3d4 = Port, P3c4 = Port - 0x10;
 
 	/* keep following setting sequence, each setting in
-	 * the same reg insert idle */
+	 * the same reg insert idle 
+	 */
 	xgifb_reg_set(P3d4, 0x82, 0x77);
 	xgifb_reg_set(P3d4, 0x86, 0x00);
 	xgifb_reg_get(P3d4, 0x86); /* Insert read command for delay */
@@ -698,11 +700,11 @@ static void XGINew_CheckChannel(struct xgi_hw_device_info *HwDeviceExtension,
 		break;
 	case XG42:
 		/*
-		 XG42 SR14 D[3] Reserve
-		 D[2] = 1, Dual Channel
-		 = 0, Single Channel
-
-		 It's Different from Other XG40 Series.
+		 * XG42 SR14 D[3] Reserve
+		 * D[2] = 1, Dual Channel
+		 * = 0, Single Channel
+		 *
+		 * It's Different from Other XG40 Series.
 		 */
 		if (XGINew_CheckFrequence(pVBInfo) == 1) { /* DDRII, DDR2x */
 			pVBInfo->ram_bus = 32; /* 32 bits */
-- 
2.5.0

Re: [Outreachy kernel] [PATCH v2] staging: xgifb: Fix comment style

[Greg KH]

On Sat, Feb 13, 2016 at 05:09:36PM -0500, Janani Ravichandran wrote:
> Fix comments to use trailing */ on separate lines and * on subsequent
> lines. Found by checkpatch.pl 
> 
> Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com>
> ---
> Changes since v1:
>  * Corrected accidentally modified comment in line 56 in the previous
>    patch

Always run your patches through checkpatch so you don't get grumpy
emails from maintainers telling you to run your patch through
checkpatch...

I can't take this :(

Re: [Outreachy kernel] [PATCH v2] staging: xgifb: Fix comment style

[Janani Ravichandran]

[-- Attachment #1: Type: text/plain, Size: 711 bytes --]

On Sun, Feb 14, 2016 at 7:44 PM, Greg KH <gregkh@linuxfoundation.org> wrote:

> On Sat, Feb 13, 2016 at 05:09:36PM -0500, Janani Ravichandran wrote:
> > Fix comments to use trailing */ on separate lines and * on subsequent
> > lines. Found by checkpatch.pl
> >
> > Signed-off-by: Janani Ravichandran <janani.rvchndrn@gmail.com>
> > ---
> > Changes since v1:
> >  * Corrected accidentally modified comment in line 56 in the previous
> >    patch
>
> Always run your patches through checkpatch so you don't get grumpy
> emails from maintainers telling you to run your patch through
> checkpatch...
>
> I can't take this :(
>
> Greg, sorry about that. Just realized I sent you the wrong one. Sent v3
now.

Janani.

[-- Attachment #2: Type: text/html, Size: 1294 bytes --]