From: Sebastian Reichel <sre@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power: collie_battery: hide unused variable
Date: Mon, 15 Feb 2016 06:03:09 +0100 [thread overview]
Message-ID: <20160215050308.GD28626@earth> (raw)
In-Reply-To: <1453736756-1959377-2-git-send-email-arnd@arndb.de>
[-- Attachment #1: Type: text/plain, Size: 485 bytes --]
Hi,
On Mon, Jan 25, 2016 at 04:45:49PM +0100, Arnd Bergmann wrote:
> The 'wakeup_enabled' variable in this driver is only accessed
> by the optional power management functions and we get a warning
> when they are disabled:
>
> drivers/power/collie_battery.c:29:12: error: 'wakeup_enabled' defined but not used [-Werror=unused-variable]
>
> This moves the definition next to the users inside the same #ifdef,
> which avoids the warning.
Thanks, queued.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: sre@kernel.org (Sebastian Reichel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] power: collie_battery: hide unused variable
Date: Mon, 15 Feb 2016 06:03:09 +0100 [thread overview]
Message-ID: <20160215050308.GD28626@earth> (raw)
In-Reply-To: <1453736756-1959377-2-git-send-email-arnd@arndb.de>
Hi,
On Mon, Jan 25, 2016 at 04:45:49PM +0100, Arnd Bergmann wrote:
> The 'wakeup_enabled' variable in this driver is only accessed
> by the optional power management functions and we get a warning
> when they are disabled:
>
> drivers/power/collie_battery.c:29:12: error: 'wakeup_enabled' defined but not used [-Werror=unused-variable]
>
> This moves the definition next to the users inside the same #ifdef,
> which avoids the warning.
Thanks, queued.
-- Sebastian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160215/07779cfd/attachment.sig>
next prev parent reply other threads:[~2016-02-15 5:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 15:45 [PATCH] power: collie_battery: hide unused variable Arnd Bergmann
2016-01-25 15:45 ` Arnd Bergmann
2016-01-30 16:16 ` Pavel Machek
2016-01-30 16:16 ` Pavel Machek
2016-02-15 5:03 ` Sebastian Reichel [this message]
2016-02-15 5:03 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160215050308.GD28626@earth \
--to=sre@kernel.org \
--cc=arnd@arndb.de \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.