From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: lkp@lists.01.org
Subject: Re: [printk] af097cab1b: EIP is at vprintk_emit+0xab2/0xb5c
Date: Mon, 15 Feb 2016 22:20:34 +0900 [thread overview]
Message-ID: <20160215132034.GA447@swordfish> (raw)
In-Reply-To: <87vb5qd9yu.fsf@yhuang-dev.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1169 bytes --]
On (02/15/16 09:43), kernel test robot wrote:
> FYI, we noticed the below changes on
>
> https://github.com/0day-ci/linux Sergey-Senozhatsky/printk-move-can_use_console-out-of-console_trylock_for_printk/20160213-024210
> commit af097cab1b878d5be746be8bcaa9a79986716c41 ("printk: set may_schedule for some of console_trylock callers")
Hello,
thanks for reporting,
any chance you can test the patch below?
---
kernel/printk/printk.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index 9917f69..7268a40 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -2208,7 +2208,7 @@ void console_unlock(void)
static u64 seen_seq;
unsigned long flags;
bool wake_klogd = false;
- bool do_cond_resched, retry;
+ bool do_cond_resched, retry = false;
if (console_suspended) {
up_console_sem();
@@ -2241,7 +2241,8 @@ again:
}
/* flush buffered message fragment immediately to console */
- console_cont_flush(text, sizeof(text));
+ if (!retry)
+ console_cont_flush(text, sizeof(text));
for (;;) {
struct printk_log *msg;
WARNING: multiple messages have this Message-ID (diff)
From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: kernel test robot <ying.huang@linux.intel.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
lkp@01.org, LKML <linux-kernel@vger.kernel.org>,
0day robot <fengguang.wu@intel.com>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [lkp] [printk] af097cab1b: EIP is at vprintk_emit+0xab2/0xb5c
Date: Mon, 15 Feb 2016 22:20:34 +0900 [thread overview]
Message-ID: <20160215132034.GA447@swordfish> (raw)
In-Reply-To: <87vb5qd9yu.fsf@yhuang-dev.intel.com>
On (02/15/16 09:43), kernel test robot wrote:
> FYI, we noticed the below changes on
>
> https://github.com/0day-ci/linux Sergey-Senozhatsky/printk-move-can_use_console-out-of-console_trylock_for_printk/20160213-024210
> commit af097cab1b878d5be746be8bcaa9a79986716c41 ("printk: set may_schedule for some of console_trylock callers")
Hello,
thanks for reporting,
any chance you can test the patch below?
---
kernel/printk/printk.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index 9917f69..7268a40 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -2208,7 +2208,7 @@ void console_unlock(void)
static u64 seen_seq;
unsigned long flags;
bool wake_klogd = false;
- bool do_cond_resched, retry;
+ bool do_cond_resched, retry = false;
if (console_suspended) {
up_console_sem();
@@ -2241,7 +2241,8 @@ again:
}
/* flush buffered message fragment immediately to console */
- console_cont_flush(text, sizeof(text));
+ if (!retry)
+ console_cont_flush(text, sizeof(text));
for (;;) {
struct printk_log *msg;
next prev parent reply other threads:[~2016-02-15 13:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 1:43 [printk] af097cab1b: EIP is at vprintk_emit+0xab2/0xb5c kernel test robot
2016-02-15 1:43 ` [lkp] " kernel test robot
2016-02-15 13:20 ` Sergey Senozhatsky [this message]
2016-02-15 13:20 ` Sergey Senozhatsky
2016-02-15 16:04 ` Sergey Senozhatsky
2016-02-15 16:04 ` [lkp] " Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160215132034.GA447@swordfish \
--to=sergey.senozhatsky@gmail.com \
--cc=lkp@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.