From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: David Marchand <david.marchand@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v3 3/4] eal: introduce pci ioport api
Date: Tue, 16 Feb 2016 10:36:22 +0800 [thread overview]
Message-ID: <20160216023622.GD21426@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <1455542666-28895-4-git-send-email-david.marchand@6wind.com>
On Mon, Feb 15, 2016 at 02:24:25PM +0100, David Marchand wrote:
> +/**
> + * A structure used to access io resources for a pci device.
> + * rte_pci_ioport is arch, os, driver specific, and should not be used outside
> + * of pci ioport api.
> + */
> +struct rte_pci_ioport {
> + struct rte_pci_device *dev;
> + uint64_t offset;
> +};
"offset" dosen't sound like a good name to me; espeicially when I found
code like below:
reg = p->offset + offset;
Regarding that, maybe "base" is a better name? I don't like it too much,
though. Any better idea?
Otherwise, this patch looks good to me.
--yliu
next prev parent reply other threads:[~2016-02-16 2:36 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 17:55 [PATCH 0/4] rework ioport access for virtio David Marchand
2016-02-05 17:55 ` [PATCH 1/4] virtio/bsd: fix typo David Marchand
2016-02-05 17:55 ` [PATCH 2/4] virtio: fix incorrect check when mapping pci resources David Marchand
2016-02-05 17:55 ` [PATCH 3/4] eal: introduce ioport api David Marchand
2016-02-05 17:55 ` [PATCH 4/4] virtio: use " David Marchand
2016-02-07 7:48 ` [PATCH v2 0/4] rework ioport access for virtio David Marchand
2016-02-07 7:48 ` [PATCH v2 1/4] virtio/bsd: fix typo David Marchand
2016-02-07 7:48 ` [PATCH v2 2/4] virtio: fix incorrect check when mapping pci resources David Marchand
2016-02-07 7:48 ` [PATCH v2 3/4] eal: introduce pci ioport api David Marchand
2016-02-08 5:56 ` Santosh Shukla
2016-02-07 7:48 ` [PATCH v2 4/4] virtio: use " David Marchand
2016-02-08 6:01 ` Santosh Shukla
2016-02-09 3:52 ` Tetsuya Mukawa
2016-02-09 8:31 ` David Marchand
2016-02-15 13:24 ` [PATCH v3 0/4] rework ioport access for virtio David Marchand
2016-02-15 13:24 ` [PATCH v3 1/4] virtio/bsd: fix typo David Marchand
2016-02-15 13:24 ` [PATCH v3 2/4] virtio: fix incorrect check when mapping pci resources David Marchand
2016-02-15 13:24 ` [PATCH v3 3/4] eal: introduce pci ioport api David Marchand
2016-02-16 2:36 ` Yuanhan Liu [this message]
2016-02-16 6:09 ` David Marchand
2016-02-16 6:12 ` Yuanhan Liu
2016-02-15 13:24 ` [PATCH v3 4/4] virtio: use " David Marchand
2016-02-16 2:24 ` Yuanhan Liu
2016-02-16 20:37 ` [PATCH v4 0/4] rework ioport access for virtio David Marchand
2016-02-16 20:37 ` [PATCH v4 1/4] virtio/bsd: fix typo David Marchand
2016-02-16 20:37 ` [PATCH v4 2/4] virtio: fix incorrect check when mapping pci resources David Marchand
2016-02-16 20:37 ` [PATCH v4 3/4] eal: introduce pci ioport api David Marchand
2016-02-16 20:37 ` [PATCH v4 4/4] virtio: use " David Marchand
2016-02-16 21:59 ` [PATCH v4 0/4] rework ioport access for virtio Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160216023622.GD21426@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.