Re: [PATCH v2 4/4] virtio: use pci ioport api

[Tetsuya Mukawa <mukawa@igel.co.jp>]

On 2016/02/07 16:48, David Marchand wrote:
> Move all os / arch specifics to eal.
>
> Signed-off-by: David Marchand <david.marchand@6wind.com>
> ---
>  drivers/net/virtio/virtio_pci.c | 339 +++++++---------------------------------
>  drivers/net/virtio/virtio_pci.h |  38 +----
>  2 files changed, 55 insertions(+), 322 deletions(-)
>
> diff --git a/drivers/net/virtio/virtio_pci.c b/drivers/net/virtio/virtio_pci.c
> index b1610dd..e04c0db 100644
> --- a/drivers/net/virtio/virtio_pci.c
> +++ b/drivers/net/virtio/virtio_pci.c
> @@ -49,74 +49,35 @@
>
> @@ -311,132 +191,20 @@ legacy_virtio_has_msix(const struct rte_pci_addr *loc)
>  
>  /* Extract I/O port numbers from sysfs */
>  static int
> -virtio_resource_init_by_uio(struct rte_pci_device *pci_dev)
> +legacy_virtio_resource_init(struct rte_pci_device *pci_dev,
> +			    struct virtio_hw *hw)

One more legacy_virtio_resource_init() is defined like below.

#ifdef RTE_EXEC_ENV_LINUXAPP
<snip>
#else
<snip>
static int
legacy_virtio_resource_init(struct rte_pci_device *pci_dev __rte_unused)
{
        /* no setup required */
        return 0;
}
#endif

Should we change this also?

Thanks,
Tetsuya