From: Dan Carpenter <dan.carpenter@oracle.com>
To: ksenija.stanojevic@gmail.com
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org
Subject: re: iio: adc: Move mxs-lradc out of staging
Date: Tue, 16 Feb 2016 10:56:58 +0300 [thread overview]
Message-ID: <20160216075658.GA4553@mwanda> (raw)
Hello Ksenija Stanojevic,
The patch f836c4592244: "iio: adc: Move mxs-lradc out of staging"
from Feb 6, 2016, leads to the following static checker warning:
drivers/iio/adc/mxs-lradc.c:1503 mxs_lradc_hw_init()
warn: inconsistent indenting
drivers/iio/adc/mxs-lradc.c
1496 mxs_lradc_reg_wrt(lradc, 0, LRADC_DELAY(3));
1497
1498 /* Configure the touchscreen type */
1499 if (lradc->soc == IMX28_LRADC) {
1500 mxs_lradc_reg_clear(lradc, LRADC_CTRL0_MX28_TOUCH_SCREEN_TYPE,
1501 LRADC_CTRL0);
1502
1503 if (lradc->use_touchscreen == MXS_LRADC_TOUCHSCREEN_5WIRE)
1504 mxs_lradc_reg_set(lradc, LRADC_CTRL0_MX28_TOUCH_SCREEN_TYPE,
1505 LRADC_CTRL0);
Should these lines be indented more or are the curly braces misplaced?
1506 }
1507
1508 /* Start internal temperature sensing. */
1509 mxs_lradc_reg_wrt(lradc, 0, LRADC_CTRL2);
1510
1511 return 0;
regards,
dan carpenter
next reply other threads:[~2016-02-16 7:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 7:56 Dan Carpenter [this message]
2016-02-16 8:18 ` iio: adc: Move mxs-lradc out of staging Ksenija Stanojević
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160216075658.GA4553@mwanda \
--to=dan.carpenter@oracle.com \
--cc=knaack.h@gmx.de \
--cc=ksenija.stanojevic@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.