* re: iio: adc: Move mxs-lradc out of staging
@ 2016-02-16 7:56 Dan Carpenter
2016-02-16 8:18 ` Ksenija Stanojević
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2016-02-16 7:56 UTC (permalink / raw)
To: ksenija.stanojevic
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald, linux-iio
Hello Ksenija Stanojevic,
The patch f836c4592244: "iio: adc: Move mxs-lradc out of staging"
from Feb 6, 2016, leads to the following static checker warning:
drivers/iio/adc/mxs-lradc.c:1503 mxs_lradc_hw_init()
warn: inconsistent indenting
drivers/iio/adc/mxs-lradc.c
1496 mxs_lradc_reg_wrt(lradc, 0, LRADC_DELAY(3));
1497
1498 /* Configure the touchscreen type */
1499 if (lradc->soc == IMX28_LRADC) {
1500 mxs_lradc_reg_clear(lradc, LRADC_CTRL0_MX28_TOUCH_SCREEN_TYPE,
1501 LRADC_CTRL0);
1502
1503 if (lradc->use_touchscreen == MXS_LRADC_TOUCHSCREEN_5WIRE)
1504 mxs_lradc_reg_set(lradc, LRADC_CTRL0_MX28_TOUCH_SCREEN_TYPE,
1505 LRADC_CTRL0);
Should these lines be indented more or are the curly braces misplaced?
1506 }
1507
1508 /* Start internal temperature sensing. */
1509 mxs_lradc_reg_wrt(lradc, 0, LRADC_CTRL2);
1510
1511 return 0;
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: iio: adc: Move mxs-lradc out of staging
2016-02-16 7:56 iio: adc: Move mxs-lradc out of staging Dan Carpenter
@ 2016-02-16 8:18 ` Ksenija Stanojević
0 siblings, 0 replies; 2+ messages in thread
From: Ksenija Stanojević @ 2016-02-16 8:18 UTC (permalink / raw)
To: Dan Carpenter
Cc: Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald, linux-iio
Hi Dan,
On Tue, Feb 16, 2016 at 8:56 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> Hello Ksenija Stanojevic,
>
> The patch f836c4592244: "iio: adc: Move mxs-lradc out of staging"
> from Feb 6, 2016, leads to the following static checker warning:
>
> drivers/iio/adc/mxs-lradc.c:1503 mxs_lradc_hw_init()
> warn: inconsistent indenting
>
> drivers/iio/adc/mxs-lradc.c
> 1496 mxs_lradc_reg_wrt(lradc, 0, LRADC_DELAY(3));
> 1497
> 1498 /* Configure the touchscreen type */
> 1499 if (lradc->soc == IMX28_LRADC) {
> 1500 mxs_lradc_reg_clear(lradc, LRADC_CTRL0_MX28_TOUCH_SCREEN_TYPE,
> 1501 LRADC_CTRL0);
> 1502
> 1503 if (lradc->use_touchscreen == MXS_LRADC_TOUCHSCREEN_5WIRE)
> 1504 mxs_lradc_reg_set(lradc, LRADC_CTRL0_MX28_TOUCH_SCREEN_TYPE,
> 1505 LRADC_CTRL0);
>
> Should these lines be indented more or are the curly braces misplaced?
Lines should be indented more, I will send a patch.
> 1506 }
> 1507
> 1508 /* Start internal temperature sensing. */
> 1509 mxs_lradc_reg_wrt(lradc, 0, LRADC_CTRL2);
> 1510
> 1511 return 0;
>
>
Thanks,
Ksenija
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-16 8:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-16 7:56 iio: adc: Move mxs-lradc out of staging Dan Carpenter
2016-02-16 8:18 ` Ksenija Stanojević
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.