From: keith.busch@intel.com (Keith Busch)
Subject: [PATCHv2-4.5 08/10] NVMe: Move error handling to failed reset handler
Date: Tue, 16 Feb 2016 21:57:47 +0000 [thread overview]
Message-ID: <20160216215746.GB8415@localhost.localdomain> (raw)
In-Reply-To: <20160213094634.GB15318@infradead.org>
On Sat, Feb 13, 2016@01:46:34AM -0800, Christoph Hellwig wrote:
> On Thu, Feb 11, 2016@01:05:45PM -0700, Keith Busch wrote:
> > +/**
> > + * nvme_kill_ns_queues(): Ends all namespace queues
> > + * @ctrl: the dead controller that needs to end
> > + *
> > + * Call this function when the driver determines it is unable to get the
> > + * controller in a state capable of servicing IO.
> > + */
> > +void nvme_kill_ns_queues(struct nvme_ctrl *ctrl)
>
> Why do we have a separate function for this instead of driving this
> from nvme_remove_namespaces?
nvme_remove_namespaces attempts to remove namespaces assuming the
controller is still functional. For example, user pushed the "Attention"
removal button and waits for the acknowledgement.
This new API assumes the controller is not functional and never will be.
If your question is why nvme_remove_namespaces doesn't handle both cases,
it's because the controller could break/link-down only after calling
del_gendisk, at which point its too late for the driver to kill the
queue in that path.
next prev parent reply other threads:[~2016-02-16 21:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 20:05 [PATCHv2-4.5 00/10] NVMe fixes Keith Busch
2016-02-11 20:05 ` [PATCHv2-4.5 01/10] blk-mq: End unstarted requests on dying queue Keith Busch
2016-02-11 20:05 ` [PATCHv2-4.5 02/10] NVMe: Fix io incapable return values Keith Busch
2016-02-11 20:05 ` [PATCHv2-4.5 03/10] NVMe: Allow request merges Keith Busch
2016-02-11 20:05 ` [PATCHv2-4.5 04/10] NVMe: Fix namespace removal deadlock Keith Busch
2016-02-13 9:44 ` Christoph Hellwig
2016-02-11 20:05 ` [PATCHv2-4.5 05/10] NVMe: Requeue requests on suspended queues Keith Busch
2016-02-11 20:05 ` [PATCHv2-4.5 06/10] NVMe: Poll device while still active during remove Keith Busch
2016-02-11 20:05 ` [PATCHv2-4.5 07/10] NVMe: Simplify device reset failure Keith Busch
2016-02-13 9:21 ` Christoph Hellwig
2016-02-11 20:05 ` [PATCHv2-4.5 08/10] NVMe: Move error handling to failed reset handler Keith Busch
2016-02-13 9:46 ` Christoph Hellwig
2016-02-16 21:57 ` Keith Busch [this message]
2016-02-17 8:06 ` Christoph Hellwig
2016-02-11 20:05 ` [PATCHv2-4.5 09/10] NVMe: Mark queues as dead on degraded controller Keith Busch
2016-02-11 20:05 ` [PATCHv2-4.5 10/10] NVMe: Rate limit nvme IO warnings Keith Busch
2016-02-12 8:16 ` Johannes Thumshirn
2016-02-11 22:28 ` [PATCHv2-4.5 00/10] NVMe fixes Keith Busch
2016-02-11 22:38 ` Jens Axboe
2016-02-12 8:35 ` Christoph Hellwig
2016-02-12 15:09 ` Jens Axboe
2016-02-12 15:24 ` Keith Busch
2016-02-13 9:49 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160216215746.GB8415@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.