From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: xuyiping <xuyiping@hisilicon.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
YiPing Xu <xuyiping@huawei.com>,
minchan@kernel.org, ngupta@vflare.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, suzhuangluan@hisilicon.com,
puck.chen@hisilicon.com, dan.zhao@hisilicon.com
Subject: Re: [PATCH] zsmalloc: drop unused member 'mapping_area->huge'
Date: Wed, 17 Feb 2016 12:55:58 +0900 [thread overview]
Message-ID: <20160217035558.GA15278@swordfish> (raw)
In-Reply-To: <56C3E91B.1030101@hisilicon.com>
On (02/17/16 11:29), xuyiping wrote:
[..]
>
> if (off + class->size <= PAGE_SIZE) {
>
> for huge object, the code will get into this branch, there is no more huge
> object process in __zs_map_object.
correct, well, techically, it's not about huge objects, but objects that span
page boundaries. we can have objects of pretty small sizes being split between
pages, for example size:1536 and offset:3072, etc.
-ss
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: xuyiping <xuyiping@hisilicon.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
YiPing Xu <xuyiping@huawei.com>,
minchan@kernel.org, ngupta@vflare.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, suzhuangluan@hisilicon.com,
puck.chen@hisilicon.com, dan.zhao@hisilicon.com
Subject: Re: [PATCH] zsmalloc: drop unused member 'mapping_area->huge'
Date: Wed, 17 Feb 2016 12:55:58 +0900 [thread overview]
Message-ID: <20160217035558.GA15278@swordfish> (raw)
In-Reply-To: <56C3E91B.1030101@hisilicon.com>
On (02/17/16 11:29), xuyiping wrote:
[..]
>
> if (off + class->size <= PAGE_SIZE) {
>
> for huge object, the code will get into this branch, there is no more huge
> object process in __zs_map_object.
correct, well, techically, it's not about huge objects, but objects that span
page boundaries. we can have objects of pretty small sizes being split between
pages, for example size:1536 and offset:3072, etc.
-ss
next prev parent reply other threads:[~2016-02-17 3:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 1:56 [PATCH] zsmalloc: drop unused member 'mapping_area->huge' YiPing Xu
2016-02-17 1:56 ` YiPing Xu
2016-02-17 2:26 ` Sergey Senozhatsky
2016-02-17 2:26 ` Sergey Senozhatsky
2016-02-17 3:29 ` xuyiping
2016-02-17 3:29 ` xuyiping
2016-02-17 3:55 ` Sergey Senozhatsky [this message]
2016-02-17 3:55 ` Sergey Senozhatsky
2016-02-17 5:20 ` Sergey Senozhatsky
2016-02-17 5:20 ` Sergey Senozhatsky
2016-02-17 15:37 ` Minchan Kim
2016-02-17 15:37 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160217035558.GA15278@swordfish \
--to=sergey.senozhatsky.work@gmail.com \
--cc=dan.zhao@hisilicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=puck.chen@hisilicon.com \
--cc=suzhuangluan@hisilicon.com \
--cc=xuyiping@hisilicon.com \
--cc=xuyiping@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.