From: Alison Schofield <amsfield22@gmail.com>
To: outreachy-kernel@googlegroups.com
Subject: [PATCH] staging: vt6656: use 0 in test for successful urb status
Date: Wed, 17 Feb 2016 09:09:27 -0800 [thread overview]
Message-ID: <20160217170915.GA4387@d830.WORKGROUP> (raw)
Replace STATUS_SUCCESS with 0 in urb->status test.
Successful usb status is simply 0. STATUS_SUCCESS is defined
for NDIS status in this driver, but was being misused in this case.
Signed-off-by: Alison Schofield <amsfield22@gmail.com>
---
drivers/staging/vt6656/usbpipe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6656/usbpipe.c b/drivers/staging/vt6656/usbpipe.c
index f27eb9a..5551b4f 100644
--- a/drivers/staging/vt6656/usbpipe.c
+++ b/drivers/staging/vt6656/usbpipe.c
@@ -116,7 +116,7 @@ static void vnt_start_interrupt_urb_complete(struct urb *urb)
break;
}
- if (status != STATUS_SUCCESS) {
+ if (status != 0) {
priv->int_buf.in_use = false;
dev_dbg(&priv->usb->dev, "%s status = %d\n", __func__, status);
--
2.1.4
next reply other threads:[~2016-02-17 17:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 17:09 Alison Schofield [this message]
2016-02-17 17:13 ` [Outreachy kernel] [PATCH] staging: vt6656: use 0 in test for successful urb status Julia Lawall
2016-02-17 17:23 ` Alison Schofield
2016-02-17 17:45 ` [PATCH v2] staging: vt6656: simplify tests of " Alison Schofield
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160217170915.GA4387@d830.WORKGROUP \
--to=amsfield22@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.