Re: [Outreachy kernel] [PATCH] staging: vt6656: use 0 in test for successful urb status

[Alison Schofield <amsfield22@gmail.com>]

On Wed, Feb 17, 2016 at 12:13:18PM -0500, Julia Lawall wrote:
> 
> 
> On Wed, 17 Feb 2016, Alison Schofield wrote:
> 
> > Replace STATUS_SUCCESS with 0 in urb->status test.
> >
> > Successful usb status is simply 0.  STATUS_SUCCESS is defined
> > for NDIS status in this driver, but was being misused in this case.
> 
> Maybe if (status) would be more normal.

got it..making it more normal, and propogating to one other instance in file.

> 
> julia
> 
> > Signed-off-by: Alison Schofield <amsfield22@gmail.com>
> > ---
> >  drivers/staging/vt6656/usbpipe.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/vt6656/usbpipe.c b/drivers/staging/vt6656/usbpipe.c
> > index f27eb9a..5551b4f 100644
> > --- a/drivers/staging/vt6656/usbpipe.c
> > +++ b/drivers/staging/vt6656/usbpipe.c
> > @@ -116,7 +116,7 @@ static void vnt_start_interrupt_urb_complete(struct urb *urb)
> >  		break;
> >  	}
> >
> > -	if (status != STATUS_SUCCESS) {
> > +	if (status != 0) {
> >  		priv->int_buf.in_use = false;
> >
> >  		dev_dbg(&priv->usb->dev, "%s status = %d\n", __func__, status);
> > --
> > 2.1.4
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160217170915.GA4387%40d830.WORKGROUP.
> > For more options, visit https://groups.google.com/d/optout.
> >