Re: [kvm-unit-tests PATCH v5 02/18] Makefile: cscope: also look in arch shared asm

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1448 bytes --]

On Wed, Feb 17, 2016 at 07:40:43PM +0100, Andrew Jones wrote:
> Signed-off-by: Andrew Jones <drjones@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

Looks sane as best as I can tell, though I don't know much about
cscope or the kvm-unit-tests makefiles.

> 
> ---
> Not exactly related to the powerpc initial drop, but ppc64 will
> need it too.
> ---
>  Makefile | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 0be2b6670daf6..fe5cc620d473b 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -85,9 +85,11 @@ distclean: clean libfdt_clean
>  	$(RM) lib/asm config.mak $(TEST_DIR)-run test.log msr.out cscope.*
>  	$(RM) -r tests
>  
> -cscope: common_dirs = lib lib/libfdt lib/linux lib/asm lib/asm-generic
> +cscope: cscope_dirs = lib lib/libfdt lib/linux
> +cscope: cscope_dirs += lib/$(ARCH)/asm lib/$(TEST_DIR)/asm lib/asm-generic
> +cscope: cscope_dirs += $(TEST_DIR) lib/$(TEST_DIR) lib/$(ARCH)
>  cscope:
>  	$(RM) ./cscope.*
> -	find -L $(TEST_DIR) lib/$(TEST_DIR) lib/$(ARCH) $(common_dirs) -maxdepth 1 \
> +	find -L $(cscope_dirs) -maxdepth 1 \
>  		-name '*.[chsS]' -print | sed 's,^\./,,' | sort -u > ./cscope.files
>  	cscope -bk

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]