From: David Sterba <dsterba@suse.cz>
To: Anand Jain <anand.jain@oracle.com>
Cc: Chris Mason <clm@fb.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Josef Bacik <jbacik@fb.com>,
kernel-janitors@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [patch] btrfs: array overflow in btrfs_ioctl_rm_dev_v2()
Date: Thu, 18 Feb 2016 08:58:25 +0000 [thread overview]
Message-ID: <20160218085825.GU4374@suse.cz> (raw)
In-Reply-To: <56C56F3C.3030408@oracle.com>
On Thu, Feb 18, 2016 at 03:14:04PM +0800, Anand Jain wrote:
>
>
> Thanks Dan.
> Chris pointed out as well. We are working on it..
In for next since yesterday.
> Just one concern when device is added the max device length is
> BTRFS_PATH_NAME_MAX. However below fix is proper from the vol_args
> perspective.
Yeah, there's mess in the various PATH constants, but they're all > 4000
and that should be enough for most uses.
WARNING: multiple messages have this Message-ID (diff)
From: David Sterba <dsterba@suse.cz>
To: Anand Jain <anand.jain@oracle.com>
Cc: Chris Mason <clm@fb.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Josef Bacik <jbacik@fb.com>,
kernel-janitors@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [patch] btrfs: array overflow in btrfs_ioctl_rm_dev_v2()
Date: Thu, 18 Feb 2016 09:58:25 +0100 [thread overview]
Message-ID: <20160218085825.GU4374@suse.cz> (raw)
In-Reply-To: <56C56F3C.3030408@oracle.com>
On Thu, Feb 18, 2016 at 03:14:04PM +0800, Anand Jain wrote:
>
>
> Thanks Dan.
> Chris pointed out as well. We are working on it..
In for next since yesterday.
> Just one concern when device is added the max device length is
> BTRFS_PATH_NAME_MAX. However below fix is proper from the vol_args
> perspective.
Yeah, there's mess in the various PATH constants, but they're all > 4000
and that should be enough for most uses.
next prev parent reply other threads:[~2016-02-18 8:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 5:01 [patch] btrfs: array overflow in btrfs_ioctl_rm_dev_v2() Dan Carpenter
2016-02-18 5:01 ` Dan Carpenter
2016-02-18 7:14 ` Anand Jain
2016-02-18 7:14 ` Anand Jain
2016-02-18 8:58 ` David Sterba [this message]
2016-02-18 8:58 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160218085825.GU4374@suse.cz \
--to=dsterba@suse.cz \
--cc=anand.jain@oracle.com \
--cc=clm@fb.com \
--cc=dan.carpenter@oracle.com \
--cc=jbacik@fb.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.