From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Panu Matilainen <pmatilai@redhat.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] vhost: add missing build dependency on librte_net
Date: Thu, 18 Feb 2016 21:25:49 +0800 [thread overview]
Message-ID: <20160218132549.GN21426@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <eef2b50186eea076a3a3ff9f10bd8c310a036549.1455788863.git.pmatilai@redhat.com>
On Thu, Feb 18, 2016 at 11:47:43AM +0200, Panu Matilainen wrote:
> Commit d0cf91303d73 added dependency on librte_net headers to vhost
> but did not add this to the Makefile, which makes builds
> non-deterministic. Curiously it is non-parallel build that is
> consistently broken by this missing dependency, usually it's the other
> way around, but trying to build without -j(n) fails with:
Yeah, I have confirmed it; I was wondering why I didn't meet such build
error.
>
> dpdk/lib/librte_vhost/vhost_rxtx.c:41:20:
> fatal error: rte_ip.h: No such file or directory
>
> Fixes: d0cf91303d73 ("vhost: add Tx offload capabilities")
> Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Thanks.
BTW, please cc me for virtio/vhost patches next time, otherwise, it's
easily got overlooked: too many emails.
--yliu
next prev parent reply other threads:[~2016-02-18 13:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 9:47 [PATCH] vhost: add missing build dependency on librte_net Panu Matilainen
2016-02-18 13:25 ` Yuanhan Liu [this message]
2016-02-18 13:39 ` Panu Matilainen
2016-02-18 13:56 ` Yuanhan Liu
2016-02-18 14:07 ` Panu Matilainen
2016-02-19 1:56 ` Yuanhan Liu
2016-02-19 10:24 ` Thomas Monjalon
2016-02-23 15:34 ` Bruce Richardson
2016-02-18 19:26 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160218132549.GN21426@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=pmatilai@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.