Re: [PATCH] vhost: add missing build dependency on librte_net

[Yuanhan Liu <yuanhan.liu@linux.intel.com>]

On Thu, Feb 18, 2016 at 03:39:26PM +0200, Panu Matilainen wrote:
> On 02/18/2016 03:25 PM, Yuanhan Liu wrote:
> >On Thu, Feb 18, 2016 at 11:47:43AM +0200, Panu Matilainen wrote:
> >>Commit d0cf91303d73 added dependency on librte_net headers to vhost
> >>but did not add this to the Makefile, which makes builds
> >>non-deterministic. Curiously it is non-parallel build that is
> >>consistently broken by this missing dependency, usually it's the other
> >>way around, but trying to build without -j(n) fails with:
> >
> >Yeah, I have confirmed it; I was wondering why I didn't meet such build
> >error.
> >
> >>
> >>	dpdk/lib/librte_vhost/vhost_rxtx.c:41:20:
> >>	fatal error: rte_ip.h: No such file or directory
> >>
> >>Fixes: d0cf91303d73 ("vhost: add Tx offload capabilities")
> >>Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
> >
> >Acked-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> >
> >Thanks.
> >
> >BTW, please cc me for virtio/vhost patches next time, otherwise, it's
> >easily got overlooked: too many emails.
> 
> Hmm, I thought I did. Looking more carefully now, I mixed up the patch
> author (who was CC'd) with you:

I didn't see the author was cc'ed from my email client:

    Date: Thu, 18 Feb 2016 11:47:43 +0200
    From: Panu Matilainen <pmatilai@redhat.com>
    To: dev@dpdk.org
    Subject: [dpdk-dev] [PATCH] vhost: add missing build dependency on librte_net

> 
> commit d0cf91303d731997945420832ee245b21f292e19
> Author: Jijiang Liu <jijiang.liu@intel.com>
> 
> I hate it when people call me Paul (commonly happens) just because it

Hmm... I didn't call you that, right?

> vaguely resembles my name,

Indeed :)

> so I really should do better than this.
> Apologies, I'll pay closer attention in the future.

Never mind, it's not a big deal. Emails with me CC'ed are highlighted
in my mutt email client, therefore, it's unlikely I will miss them.

	--yliu