All of lore.kernel.org
 help / color / mirror / Atom feed
From: hch@lst.de (Christoph Hellwig)
Subject: NVMe wwid revisited
Date: Thu, 18 Feb 2016 14:28:56 +0100	[thread overview]
Message-ID: <20160218132856.GA5150@lst.de> (raw)
In-Reply-To: <56C5C15C.8030903@suse.de>

On Thu, Feb 18, 2016@02:04:28PM +0100, Hannes Reinecke wrote:
> Hi Keith,
> 
> I've had a look at the current NVMe implementation for SCSI VPD page
> 0x83, in order to implement a generic 'wwid' field.
> 
> And I've even looked at the NVM-Express-SCSI-Translation Reference
> version 1.1. What a mess :-(

There is a version 1.5 by now..

> So I guess they actually meant for the designator type to be of T-10
> Vendor Identification (ie designator type 1).

The 1.5 spec has actually fixed this up:

6.1.4.3 T10 Vendor ID Based Descriptor

...

DESIGNATOR TYPE  |  Shall be set to 1h indicating T10 vendor ID based format.

> Which, of course, raises the question: What _is_ the correct
> identification?
> Implement it according to the translation spec, leaving out the 'T10
> Vendor Identification' field?
> Or implement it with the correct designator type?

Leave it as-is, given a certain Linux distributor started using it for
their udev rules and we'd otherwise break their setup.

  reply	other threads:[~2016-02-18 13:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-18 13:04 NVMe wwid revisited Hannes Reinecke
2016-02-18 13:28 ` Christoph Hellwig [this message]
2016-02-18 15:10   ` Keith Busch
2016-02-18 15:39     ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160218132856.GA5150@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.